Giter Club home page Giter Club logo

Comments (6)

Hexagon avatar Hexagon commented on May 14, 2024 2

Great, tried to reproduce it using different techniques, but this is the only one that finish the scheduled function, but keep node running "unexpectedly".

const Cron = require("croner");

async function runsToInfinity() { setTimeout(runsToInfinity, 1000); }

const job = Cron('* * * * * *', async (self) => {

    // No await
    runsToInfinity();

    // Option 1, will not stop execution
    console.log('Yay, done!');
    self.stop();
} );

// Option 2 (wait 2 seconds to make sure execution is started)
// ... will not stop execution either
setTimeout( () => { 
    console.log('Yay, done again!'); 
    job.stop(); 
}, 2000);

from croner.

davoam avatar davoam commented on May 14, 2024 1

Hmm, croner does not fork processes or anything, it's basically a setTimeout, where .stop() run clearTimeout. Are you sure your scheduled function does not leave anything running?

If croner causes this, it would be awesome if you could pinpoint the problem and paste some code here, so i can have a look at it :)

I'll try, when I have time :) Thanks!

from croner.

Hexagon avatar Hexagon commented on May 14, 2024

Yeah, you can stop it from both "inside" and "outside".

const job = Cron('xxx', (_job) => { /* option 1 */ _job.stop();});

// Option 2
job.stop();

Works? :)

See internal test suite for examples of promise handling https://github.com/Hexagon/croner/blob/master/test/src/suite.cjs

from croner.

davoam avatar davoam commented on May 14, 2024

Thanks for the quick response! Yeah, I stopped all the jobs this way, but the process itself keeps running. If there are no running jobs, croner stops the process?

It seems like there is a pending setTimeout or Promise which prevents the process from being killed

from croner.

Hexagon avatar Hexagon commented on May 14, 2024

Hmm, croner does not fork processes or anything, it's basically a setTimeout, where .stop() run clearTimeout. Are you sure your scheduled function does not leave anything running?

If croner causes this, it would be awesome if you could pinpoint the problem and paste some code here, so i can have a look at it :)

from croner.

Hexagon avatar Hexagon commented on May 14, 2024

Closing this, since there are no steps to reproduce.

Please reopen if you find and document a way to reproduce this

from croner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.