Feature request -- allow updating of single custom attribute instead of whole list about python-hponeview HOT 2 CLOSED

Issue here seems to be that server_profile['osDeploymentSettings']['osCustomAttributes'] is a list of dicts, so its indexes would actually be numbers.

In the case presented:

profile_to_update['osDeploymentSettings']['osCustomAttributes'] = dict(name='key2',value='new2')
profile_updated = oneview_client.server_profiles.update(resource=profile_to_update, id_or_uri=profile_to_update['uri'])

This first line is actively rewriting all the contents of profile_to_update['osDeploymentSettings']['osCustomAttributes'] to match the new value of dict(name='key2',value='new2').

Changing only the second value could be achieved by pointing to the specific position we want changed, 1 in this case, since lists start at 0:

profile_to_update['osDeploymentSettings']['osCustomAttributes'][1] = dict(name='key2',value='new2')

A worse case is when we aren't sure which position we actually want to change, just the value of the key.

In that case, one option is to iterate through each item of the list and if the key matches what we want, we alter the value referenced by that key:

>>> my_list
[{'name': 'key1', 'value': 'value1'}, {'name': 'key2', 'value': 'value2'}, {'name': 'key3', 'value': 'value3'}]
>>> for i in my_list:
...     if i['name'] is 'key2':
...             i['value'] = 'new_value'
...
>>> my_list
[{'name': 'key1', 'value': 'value1'}, {'name': 'key2', 'value': 'new_value'}, {'name': 'key3', 'value': 'value3'}]

So, for now "updating select custom attributes" can be achieved in relatively straightforward ways. Not entirely sure how much benefit a helper method would bring.

@kmullican, let me know your thoughts on this after these solutions.

from python-hponeview.

This feature request has been idle for a while and it appears to be resolved by this comment, so I'm closing it down.

If the solution provided does not satisfy your needs, this issue should be reopened or referenced through a new issue.

from python-hponeview.