v1.6.0: Targets are not adding to the load balancer about hcloud-cloud-controller-manager HOT 8 CLOSED

The "bug" i wrote above was fixed with v1.6.1 (which was just released)

from hcloud-cloud-controller-manager.

Sorry for wakening up this dead cow....

Would it be, for testing issues, acceptable to add an option to hccm which allows to use masters for load balancers if explicitely requested by the one deploying hccm? Removing the master label from the node can have side effects if some applications explicitely require to be scheduled on a master node.

from hcloud-cloud-controller-manager.

I've just went into this issue, and if anyone still wondering...

In current 1.28 Kubernetes you need to remove node.kubernetes.io/exclude-from-external-load-balancers label if you want your master to be added as target server.

from hcloud-cloud-controller-manager.

Masters are not reachable for Load Balancers by design: kubernetes/kubernetes#65618

You could unlabel the node: kubectl label node test node-role.kubernetes.io/master- then it will work.

We found another small bug while reproducing your testcase. You can try:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: echoserver
spec:
  replicas: 1
  selector:
    matchLabels:
      app: echoserver
  template:
    metadata:
      labels:
        app: echoserver
    spec:
      containers:
      - image: gcr.io/google_containers/echoserver:1.10
        imagePullPolicy: Always
        name: echoserver
        ports:
        - containerPort: 8080
---
apiVersion: v1
kind: Service
metadata:
  name: echoserver
  annotations:
   load-balancer.hetzner.cloud/location: hel1
   load-balancer.hetzner.cloud/health-check-interval: 15
spec:
  type: LoadBalancer
  ports:
  - port: 80
    targetPort: 8080
    protocol: TCP
  selector:
    app: echoserver

Until the bugfix release.

from hcloud-cloud-controller-manager.

Are there no other implications of removing the label from the master node? This will not cause other things to stop working?

from hcloud-cloud-controller-manager.

@BouweCeunen actually this is not a limitation from our side. This is something that comes from the k8s people.

from hcloud-cloud-controller-manager.

@BouweCeunen actually this is not a limitation from our side. This is something that comes from the k8s people.

Indeed, just thought that someone would have done it and experienced some side effects. Will take it to the community!

from hcloud-cloud-controller-manager.

Yes, adding or removing this annotation is the best way to exclude nodes from the load balancer targets.

from hcloud-cloud-controller-manager.