Giter Club home page Giter Club logo

Comments (4)

AlekSi avatar AlekSi commented on August 16, 2024 1

Apache license, like most open source software licenses, requires attribution. If DigitalOcean's code was indeed used, this fact must be mentioned.

In #3 the lines in question were silently removed. That raises a red flag.

from hcloud-cloud-controller-manager.

thetechnick avatar thetechnick commented on August 16, 2024

We do not share code with the digital ocean repository.
The main.go file which is derived in both implementations from the kubernetes projects controller-manager.go file: https://github.com/kubernetes/kubernetes/blob/master/cmd/cloud-controller-manager/controller-manager.go
Which should be used for this purpose:
https://kubernetes.io/docs/tasks/administer-cluster/developing-cloud-controller-manager/

Other similarities are due to the fact that there are only so many ways to sanely implement the same functionality.

from hcloud-cloud-controller-manager.

AlekSi avatar AlekSi commented on August 16, 2024

The main.go file which is derived in both implementations from the kubernetes projects controller-manager.go file: https://github.com/kubernetes/kubernetes/blob/master/cmd/cloud-controller-manager/controller-manager.go

It looks very different to me.

Other similarities are due to the fact that there are only so many ways to sanely implement the same functionality.

Ok, how can you explain this and this? It is taken verbatim with comments and formatting. I doubt there is only the single way to write that sentence.

from hcloud-cloud-controller-manager.

slintes avatar slintes commented on August 16, 2024

Just curious: even if it would be a fork, what is your problem? Both use the Apache v2 license which allows it afaik.
Disclaimer: I'm a customer of Hetzer only

from hcloud-cloud-controller-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.