I'm unable to instantiate the Cortex class in either the notebooks or directly in Pyth

The issue is in pylissom.math.normalize: <div class="snippet-clipboard-content not

Cortex class throw on instantiation about pylissom HOT 2 OPEN

hernanbari commented on August 25, 2024

Cortex class throw on instantiation

from pylissom.

Comments (2)

davidljung commented on August 25, 2024

Same exception on Ubuntu 18.04 with Python 3.6.9 & PyTorch 1.3.1

from pylissom.

davidljung commented on August 25, 2024

The issue is in pylissom.math.normalize:

def normalize(matrix, norm=1, axis=1):
    """
    This function implements a normalization of the row or column vectors of a matrix
    (by default, normalizes the columns and uses norm 1).
    Args:
        matrix: input matrix
        norm: Dimension of the norm
        axis: 0 is column, 1 is row
    Returns:
        A matrix normalized by columns or rows
    """
    matrix_norms = matrix.norm(p=norm, dim=axis)
    return matrix.div(matrix_norms.expand_as(matrix))

I'm not 100% sure I understand the intended behaviour, but making the following change:

    matrix_norms = matrix.norm(p=norm, dim=axis).reshape(-1 if axis==1 else 1,1 if axis==1 else -1)

to add a singleton dimension, seems to result in the function dividing each element by its row or col norm.
(possibly a more elegant way to implement it)

That fixes the exception on instantiation of Cortex. However, the UserWarning mentioned is still present.

from pylissom.

Recommend Projects