Giter Club home page Giter Club logo

Comments (5)

henrycatalinismith avatar henrycatalinismith commented on August 30, 2024

Ah, I see. I'll sort this out ASAP. Thanks for letting me know!

from ppl.

pigmonkey avatar pigmonkey commented on August 30, 2024

This now works fine in 1.16.0.

The only issue is that the first line still returns the total number of contacts and the total number of matching contacts. This doesn't impact the functionality, but may be confusing for some users.

$ ppl mutt joe
Searching address book... 12 entries... 1 matching:
[email protected]        Joe Schmoe
[email protected]        Joe Schmoe

There is 1 matching contact, but ppl is returning emails, not contacts, so there are 2 matching values. I may have only 12 contacts, but I have more than 12 total emails for those contacts.

I think it makes the most sense for ppl to report something like:

Searching address book...18 emails... 2 matching:

Or the total number of contacts could still be reported:

Searching address book... 12 entries...18 emails... 2 matching:

from ppl.

henrycatalinismith avatar henrycatalinismith commented on August 30, 2024

Agreed. To be completely honest, I simply didn't stop and think about that "one line message" when I was implementing this.

I like your first suggestion the most. It gets rid of that vague word "entries" (which I copied from the documentation without much thought), and it's clear what both numbers are about. Plus when you're using this functionality to find email addresses, what you're probably interested in are the sets of email addresses and matching email addresses. Let's run with that. Unless any bugs come up in the meantime, this will be 1.16.1.

from ppl.

pigmonkey avatar pigmonkey commented on August 30, 2024

I feel like I'm causing a lot of version bumps!

from ppl.

henrycatalinismith avatar henrycatalinismith commented on August 30, 2024

It's very welcome, man. I'm a big fan of "sweating the little things" when it comes to little details like that "Searching address book" message above. And the feature requests are good stuff too. For a project as esoteric as ppl, it's actually just nice to know that people are even trying it.

from ppl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.