Comments (5)
Ah, I see. I'll sort this out ASAP. Thanks for letting me know!
from ppl.
This now works fine in 1.16.0.
The only issue is that the first line still returns the total number of contacts and the total number of matching contacts. This doesn't impact the functionality, but may be confusing for some users.
$ ppl mutt joe
Searching address book... 12 entries... 1 matching:
[email protected] Joe Schmoe
[email protected] Joe Schmoe
There is 1 matching contact, but ppl is returning emails, not contacts, so there are 2 matching values. I may have only 12 contacts, but I have more than 12 total emails for those contacts.
I think it makes the most sense for ppl to report something like:
Searching address book...18 emails... 2 matching:
Or the total number of contacts could still be reported:
Searching address book... 12 entries...18 emails... 2 matching:
from ppl.
Agreed. To be completely honest, I simply didn't stop and think about that "one line message" when I was implementing this.
I like your first suggestion the most. It gets rid of that vague word "entries" (which I copied from the documentation without much thought), and it's clear what both numbers are about. Plus when you're using this functionality to find email addresses, what you're probably interested in are the sets of email addresses and matching email addresses. Let's run with that. Unless any bugs come up in the meantime, this will be 1.16.1
.
from ppl.
I feel like I'm causing a lot of version bumps!
from ppl.
It's very welcome, man. I'm a big fan of "sweating the little things" when it comes to little details like that "Searching address book" message above. And the feature requests are good stuff too. For a project as esoteric as ppl, it's actually just nice to know that people are even trying it.
from ppl.
Related Issues (20)
- include ppl edit <any-identifier> HOT 1
- Bash completion needs to escape shell tokens HOT 1
- Some questions about features and refactoring HOT 4
- Convert to use the vcard gem HOT 3
- Add support for the KIND field HOT 1
- Add support for the RELATED field HOT 1
- Add support for the NOTE field HOT 1
- Test out using the Thor gem for the CLI HOT 1
- Add more code quality tools and their badges HOT 5
- setting nickname erases name details in the vcard HOT 6
- autocomplete fails when it encounters invalid dates in the data set HOT 2
- ppl is destructively intolerant of tags it doesn't recognize HOT 1
- Colorized and aligned custom address book format HOT 1
- Not sure if Ruby version checking is doing the intended thing HOT 2
- Undo "ppl init" HOT 3
- create brew install HOT 1
- Mac/iOS integration HOT 1
- Windows OS Support HOT 1
- Strange error about "undefined method `version' for nil:NilClass (NoMethodError)" HOT 2
- ERROR: Failed to build gem native extension. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ppl.