Output of helm version : <div class="snippet-clip

The update strategies of Native-Resource and Custom-Resource are different when upgrading about helm HOT 2 OPEN

rudyares commented on June 13, 2024

The update strategies of Native-Resource and Custom-Resource are different when upgrading

from helm.

Comments (2)

rudyares commented on June 13, 2024

Oh, I seem to know the issue because there is no patch created from currentObj. Why don't we create patch as follows, any other considerations?

if isUnstructured || isCRD {
	// fall back to generic JSON merge patch
	patch, err := jsonpatch.CreateMergePatch(currentData, newData)
	return patch, types.MergePatchType, err
}

from helm.

gjenkins8 commented on June 13, 2024

Unfortunately, Custom resources fall back to standard json patching:

helm/pkg/kube/client.go

Lines 638 to 651 in 847369c

 // Unstructured objects, such as CRDs, may not have an not registered error 

 // returned from ConvertToVersion. Anything that's unstructured should 

 // use the jsonpatch.CreateMergePatch. Strategic Merge Patch is not supported 

 // on objects like CRDs. 

 _, isUnstructured := versionedObject.(runtime.Unstructured) 

 // On newer K8s versions, CRDs aren't unstructured but has this dedicated type 

 _, isCRD := versionedObject.(*apiextv1beta1.CustomResourceDefinition) 

 if isUnstructured || isCRD { 

 // fall back to generic JSON merge patch 

 patch, err := jsonpatch.CreateMergePatch(oldData, newData) 

 return patch, types.MergePatchType, err 

 }

This (iiuc) is because the strategicpatch library didn't support non-native types when this was implemented. I think this now might have changed, but the behavior has been retained for compatibility reasons.

from helm.

The update strategies of Native-Resource and Custom-Resource are different when upgrading about helm HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// Unstructured objects, such as CRDs, may not have an not registered error
	// returned from ConvertToVersion. Anything that's unstructured should
	// use the jsonpatch.CreateMergePatch. Strategic Merge Patch is not supported
	// on objects like CRDs.
	_, isUnstructured := versionedObject.(runtime.Unstructured)

	// On newer K8s versions, CRDs aren't unstructured but has this dedicated type
	_, isCRD := versionedObject.(*apiextv1beta1.CustomResourceDefinition)

	if isUnstructured \|\| isCRD {
	// fall back to generic JSON merge patch
	patch, err := jsonpatch.CreateMergePatch(oldData, newData)
	return patch, types.MergePatchType, err
	}