Giter Club home page Giter Club logo

Comments (7)

bacongobbler avatar bacongobbler commented on August 16, 2024 1

The call to cfg.Releases.Create on line 97 may migrate a Helm 2 release as the older Helm 3 metadata. That might not be compatible with Helm 3.0. I'll have to check and confirm just to be 100% sure, but in any case I wanted to reach out. In either case, updating to rc.3 will remove any doubts :)

from helm-2to3.

rimusz avatar rimusz commented on August 16, 2024

sure

from helm-2to3.

hickeyma avatar hickeyma commented on August 16, 2024

@bacongobbler This is should not be a breaking change for the plugin. No changes are required.

FYI, we would always update to the latest release of Helm 3 in any case.

from helm-2to3.

hickeyma avatar hickeyma commented on August 16, 2024

I will update once RC-3 is released.

from helm-2to3.

bacongobbler avatar bacongobbler commented on August 16, 2024

It was identified from helm/helm#6881 (comment) that this may not actually be a backwards-incompatible change. Phew!

from helm-2to3.

hickeyma avatar hickeyma commented on August 16, 2024

In middle of something at moment but will try and get to it shortly. Off hand, should be ok. Will check shortly. Thanks for reaching out @bacongobbler

from helm-2to3.

hickeyma avatar hickeyma commented on August 16, 2024

@bacongobbler Following testing, it works as expected. This is because the plugin interfaces with the Helm object field name definitions and not the persisted object field names. It would only be affected if the Helm object definitions changed and/or relevant API changed.

from helm-2to3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.