Giter Club home page Giter Club logo

Comments (9)

rimusz avatar rimusz commented on July 17, 2024 1

ok I tested the latest plugin version 0.1.4 on Windows with Helm v3 beta 4, it worked fine for me.
I installed git from https://git-scm.com/downloads and used git bash to run commands:

rimasm@windowz-helm-testing MINGW64 ~
$ helm plugin install https://github.com/helm/helm-2to3 --debug
[debug] updating https://github.com/helm/helm-2to3
[debug] symlinking C:\Users\rimasm\AppData\Local\Temp\helm\plugins\https-github.com-helm-helm-2to3 to C:\Users\rimasm\AppData\Roaming\helm\plugins\helm-2to3
plugin_install.go:75: [debug] loading plugin from C:\Users\rimasm\AppData\Roaming\helm\plugins\helm-2to3
plugin.go:60: [debug] running install hook: C:\Program Files\Git\usr\bin\sh.exe -c cd $HELM_PLUGIN_DIR; scripts/install_plugin.sh
Downloading and installing helm-2to3 v0.1.4 ...
https://github.com/helm/helm-2to3/releases/download/v0.1.4/helm-2to3_0.1.4_windows_amd64.tar.gz
Installed plugin: 2to3

rimasm@windowz-helm-testing MINGW64 ~
$ helm 2to3
Migrate and Cleanup Helm v2 configuration and releases in-place to Helm v3

Usage:
  2to3 [command]

Available Commands:
  cleanup     cleanup Helm v2 configuration, release data and Tiller deployment
  convert     migrate Helm v2 release in-place to Helm v3
  help        Help about any command
  move        migrate Helm v2 configuration in-place to Helm v3

Flags:
  -h, --help   help for 2to3

Use "2to3 [command] --help" for more information about a command.

from helm-2to3.

rimusz avatar rimusz commented on July 17, 2024

I will try to look to this when I get some free cycles

from helm-2to3.

rimusz avatar rimusz commented on July 17, 2024

I did the same tests with v0.1.6 as above, all worked fine.

from helm-2to3.

rimusz avatar rimusz commented on July 17, 2024

@nlowe does it work for you the approach I used above or do we still need to do something at our end?

from helm-2to3.

nlowe avatar nlowe commented on July 17, 2024

I'll take a look later Today and let you know

from helm-2to3.

nlowe avatar nlowe commented on July 17, 2024

I've confirmed this still doesn't work in PowerShell out of the box, users on windows will need to run this from Git Bash (or a similar prompt that provides bash on windows). Can we update the README to make this more clear? As it stands currently, users on Windows can't follow the install instructions.

Another option is to port the install script to Go and add it as a hidden sub-command, that should work out of the box on any system that the plugin supports, even if the user is missing bash.

from helm-2to3.

hickeyma avatar hickeyma commented on July 17, 2024

@bacongobbler What is expected support for plugins on Windows?

from helm-2to3.

bacongobbler avatar bacongobbler commented on July 17, 2024

Currently, plugin hooks are expected to be executed via WSL or mingw64, as the plugin hooks are all run under /bin/sh. This is true for both Helm 2 and Helm 3. It's been that way ever since plugin support was introduced in Helm 2.3.0.

https://github.com/helm/helm/blob/865c46c014cdb7622f97ae287ee92fb8a280f3a9/cmd/helm/plugin.go#L55-L58

from helm-2to3.

bacongobbler avatar bacongobbler commented on July 17, 2024

Works for me under WSL:

bacongobbler@ULTRALISK:~$ wget https://get.helm.sh/helm-v3.0.0-linux-amd64.tar.gz
bacongobbler@ULTRALISK:~$ tar xzf helm-v3.0.0-linux-amd64.tar.gz
bacongobbler@ULTRALISK:~$ ./linux-amd64/helm plugin install https://github.com/helm/helm-2to3
Downloading and installing helm-2to3 v0.2.0 ...
https://github.com/helm/helm-2to3/releases/download/v0.2.0/helm-2to3_0.2.0_linux_amd64.tar.gz
Installed plugin: 2to3

@nlowe for true Windows support for helm plugins, please follow helm/helm#7117. I opened a ticket upstream so that plugins can provide install hooks that work in a Windows environment. Thanks!

from helm-2to3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.