Giter Club home page Giter Club logo

Comments (6)

Kejax avatar Kejax commented on August 16, 2024

Regarding the waypoints property of the API. It seems that the waypoints are the supply lines, you can see them on https://helldivers.io if you enable the supply lines view

from api.

dealloc avatar dealloc commented on August 16, 2024

@Kejax I've experimented with resolving the waypoints, however since it leads to recursive parsing (as all waypoints eventually form up in a circle) it would create a lot of problems.
The only solution then would be to at some level decide to stop rendering waypoints which would make the schema inconsistent (sometimes a planet has waypoints, sometimes it doesn't).

So for the sake of consistency I'm leaving them as planet indexes, someone who needs the waypoints can map them from the indices that are returned from the API.

from api.

dealloc avatar dealloc commented on August 16, 2024

@juanlubf can you let me know if your code generator has any more issues regarding schema typing?

from api.

juanlubf avatar juanlubf commented on August 16, 2024

Hi @dealloc , thanks for your fast response. Actually, the code generator now is working perfectly fine after your changes.

However, I'm facing a new issue now, related to some numeric fields. As I said in my previous comment, I'm trying to use this API to build an app in Kotlin, and in Kotlin (don't know if this is the same in other languages), the maximum value for an integer is 2147483647, but in your API there are some fields typed as integer returning values greater than that (e.g. hash), which causes an exception when serializing the JSON. I just changed those fields to type number which translate in Kotlin to a Double. I don't know if this change would be a problem for your implementation.

Fields I had to change from integer to number -> hash, portrait_id_32, message_id_32, title_32

Again, thanks for your time.

from api.

dealloc avatar dealloc commented on August 16, 2024

@juanlubf no worries, I've changed all fields that I suspect are internal identifiers (aka _32 fields) to :number which should hopefully get your code generator back on track.

I've changed a few fields you didn't mention as they are not always filled in, so they might've caused problems in the future.

You can check out the details in 9527364
hope this work!

from api.

juanlubf avatar juanlubf commented on August 16, 2024

Seems to be working perfectly!
Thanks!

from api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.