Comments (2)
this is intentional all this does is prevent the preview when you select a completion. We still auto accept all completions when typing any character when one is selected
from helix.
I see. I suppose my expectations for why I felt it was a bug is because with the inserted preview gone, the cursor now remains at the initial spot:
![image](https://private-user-images.githubusercontent.com/19535809/308762681-fbb69e56-cd2c-4818-8908-373efdd7e813.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDkzNTg1MDksIm5iZiI6MTcwOTM1ODIwOSwicGF0aCI6Ii8xOTUzNTgwOS8zMDg3NjI2ODEtZmJiNjllNTYtY2QyYy00ODE4LTg5MDgtMzczZWZkZDdlODEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzAyVDA1NDMyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWExNzY0ZWEwYzgzOGM1MmQ0OGY1MDRjNThhNzIzMjBmOTMzMDZkODhkODJkZjY3M2FiZDZiMjNmMjMyMjRjZDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pWGoNIcoNeFICWUj1kmnyXHIa7ZOJPRrF9b7hAWp3rI)
And so if I were to press backspace, I'd expect it to delete the character before that, but it instead inserts the suggestion first and deletes a character off of it:
![image](https://private-user-images.githubusercontent.com/19535809/308762864-272efa17-326d-4b94-88f2-3ede12e69dd2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDkzNTg1MDksIm5iZiI6MTcwOTM1ODIwOSwicGF0aCI6Ii8xOTUzNTgwOS8zMDg3NjI4NjQtMjcyZWZhMTctMzI2ZC00Yjk0LTg4ZjItM2VkZTEyZTY5ZGQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzAyVDA1NDMyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4N2ZmZjU1Y2QyMzk4MDkwZmQzZjBjNGY4MjU0MmEzN2RlZTIyZWM3OWFmODUzNWJlMmU4YWMyMjA3YjNjNDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9NFhgOdnRa5Dq2tqFvoPnufuVfvUCbOWdQgN62bcJuQ)
Perhaps it's not the goal of preview-completion-insert
in particular, but it would be nice if only Enter/Return triggered the completion. That would be more in-line with how VSCode, IntelliJ IDEs, nvim-cmp, Lapce, Zed, etc. behaves as well.
from helix.
Related Issues (20)
- Consider update from old Lua grammar HOT 3
- golangci-lint-langserver not working with workspace diagnostics
- C/C++: replace dot operator with arrow operator intelligently HOT 3
- Documentation suggestions from new user
- Scroll jank HOT 3
- -
- Trust zones for project root discovery
- Syntax highlighting color changes on scroll HOT 1
- split_selection_on_newlines selects following line too HOT 1
- Support "plus" key HOT 2
- `half_page_up`/`half_page_down` does not work when combined with `align_view_center` HOT 3
- Wrap long lines in diagnostic picker HOT 2
- Some Pyright diagnostics (diagnostic-severity: hint) not displaying HOT 1
- HTML Element Highlighting doesn't work in PHP files HOT 2
- LSP Error in Lua HOT 1
- OCaml comment highlight is broken HOT 4
- Aggressive editor.scrolloff causes infinite loop HOT 2
- [Suggestion] Use Vim License HOT 1
- Escaping from repetitions conflicts with the Escape key when it's rebound. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helix.