Comments (13)
Was that with or without actual content in the buffer?
from helix.
crashes reliably with or without.
from helix.
I get the (exact, as far as I can tell) same crash when repeating an insert with "."
from helix.
I can't repro that. Both going into insert mode and holding '.' and leaving insert mode and repeating that insert by holding '.' from normal mode do not reproduce the problem for me.
from helix.
I get the (exact, as far as I can tell) same crash when repeating an insert with "."
Actually, I get a number slightly smaller than u16::MAX for the index.
I can't repro that. Both going into insert mode and holding '.' and leaving insert mode and repeating that insert by holding '.' from normal mode do not reproduce the problem for me.
Sorry, meant replace, not insert.
from helix.
I don't understand. Do you have a minimal set of keystrokes that repro?
from helix.
Strange I couldn't reproduce either problems, I use arch linux and and i3wm
from helix.
My issue is from windows. Is there a way to log terminal events out?
from helix.
Open file -> shift+r -> "asd" -> normal mode -> '.' ~10-20 times.
Seems to depend Definitely depends on the length of the buffer at the time.
On WSL Ubuntu.
from helix.
Actually, I get a number slightly smaller than u16::MAX for the index.
❯ RUST_BACKTRACE=1 hx src/main.rs
thread 'main' panicked at 'index out of bounds: the len is 4992 but the index is 65523', helix-tui/src/buffer.rs:185:14
stack backtrace:
0: rust_begin_unwind
at /rustc/625d5a693e4697bcafdd34fd1a38c281acabb8e9/library/std/src/panicking.rs:515:5
1: core::panicking::panic_fmt
at /rustc/625d5a693e4697bcafdd34fd1a38c281acabb8e9/library/core/src/panicking.rs:92:14
2: core::panicking::panic_bounds_check
at /rustc/625d5a693e4697bcafdd34fd1a38c281acabb8e9/library/core/src/panicking.rs:69:5
3: helix_tui::buffer::Buffer::set_style
4: <hx::ui::editor::EditorView as hx::compositor::Component>::render
5: hx::compositor::Compositor::render
6: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
7: tokio::park::thread::CachedParkThread::block_on
8: tokio::runtime::thread_pool::ThreadPool::block_on
9: tokio::runtime::Runtime::block_on
10: hx::main
from helix.
I got something similar:
thread 'main' panicked at 'attempt to subtract with overflow', helix-view/src/view.rs:147:19
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
I was running it in dev
And then once again with the 0.0.8 release:
λ kana helix → λ git replaced-args-parser* → hx
thread 'main' panicked at 'index out of bounds: the len is 10670 but the index is 65534', helix-tui/src/buffer.rs:185:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
hx > shift+r > asd > esc > i > .
as many times until it crashes
from helix.
Well, it's not shift+r, it's just 'a'/insert after selection. It actually doesn't seem to have to do with repeat at all. I'm getting this bug whenever the buffer length hits about 93 characters exceeds the terminal width.
Built from master.
Edit: Also occurs on resizing window when buffer length is larger than the new window size.
from helix.
If rapidly resizing the terminal, the view tree's sizing would fall out of sync and point out of bounds. c0332bd together with #70 should fix it
from helix.
Related Issues (20)
- `color-modes` artifact with splits HOT 2
- Add new command to jump to chunks instead of just words
- Paste copy exception
- pylsp async job failed timeout
- Invalid comment token in PKGBUILD files HOT 2
- Panic in statusline update #9122 HOT 2
- Alternative Python type-checking via pylsp-mypy HOT 2
- Statusline spinner not working
- Add alternative keybindings for Home, End, Delete, PageUp, PageDown keys
- .env.local file not showing in file picker HOT 1
- [Nix] trying to build `master` fails due to unlocked input HOT 1
- `lldb-vscode` has been renamed to `lldb-dap` HOT 4
- Code action bindings
- Search for matching brackets before adding one HOT 3
- Relative line number navigation not working properly
- Render artifacts with Unicode 3.2 test page HOT 2
- Change background color for each mode HOT 3
- Replace with adjacent cursors moves cursor over
- Add border/outline for ui.menu and ui.popup HOT 1
- Ignore grammars that failed to fetch when building HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helix.