LSP: Default golangci-lint config not working about helix HOT 11 CLOSED

Oh I see! By looking at hx --health, I wrongly assumed they were the same but looks like golangci-lint-langserver depends on golangci-lint so both needs to be installed for this to work.

Sorry for my mystake. Feel free to close the issue.

from helix.

And --health is reporting that it can find everything?

It's all right, it's working. I deleted it and then installed it from the Fedora repository. Thank you...

from helix.

On a fresh helix installation, after installing golangci-lint-langserver with go install github.com/nametake/golangci-lint-langserver@latest

Are you sure that go install installs the program to a path where it's inside $PATH?
I'm not a go-developer but a quick google search says that GOBIN per default is set to ~/go which isn't part of $PATH per default, hence helix isn't able to find the program as well.

from helix.

It's in my PATH, same as gopls but the executable name is golangci-lint-langserver:

I can confirm I can call golangci-lint-langserver without issue from my terminal but golangci-lint does not exist obviously.

from helix.

Hm... I see, it looks like that the default commands are somehow different (https://github.com/helix-editor/helix/blob/master/languages.toml#L139-L143) but I don't know why. Maybe someone else knows more than me or this should be fixed. @kirawi may I ask for your opinion here? Should we just update the command entry of language-server.golangci-lint-lsp.config?

from helix.

It was added in #8656 , perhaps the author @angaz can comment?

from helix.

Did you install golangci-lint?

from helix.

Oh I see! By looking at hx --health, I wrongly assumed they were the same but looks like golangci-lint-langserver depends on golangci-lint so both needs to be installed for this to work.

Sorry for my mystake. Feel free to close the issue.

Can you give me your languages.toml?

from helix.

Oh I see! By looking at hx --health, I wrongly assumed they were the same but looks like golangci-lint-langserver depends on golangci-lint so both needs to be installed for this to work.

Sorry for my mystake. Feel free to close the issue.

Can you give me your languages.toml?

It would be the default one. What problem are you trying to solve? Maybe you need to update to the latest version of Helix.

from helix.

Oh I see! By looking at hx --health, I wrongly assumed they were the same but looks like golangci-lint-langserver depends on golangci-lint so both needs to be installed for this to work.
Sorry for my mystake. Feel free to close the issue.

Can you give me your languages.toml?

It would be the default one. What problem are you trying to solve? Maybe you need to update to the latest version of Helix.

I would like golangci-lint to output messages in the editor according to the settings in golanci.yml, but this does not happen. I have the latest version of Helix.
golangci-lint and golangci-lint-langserver are installed. everything is fine with $PATH

from helix.

And --health is reporting that it can find everything?

from helix.