Giter Club home page Giter Club logo

Comments (11)

heinrichreimer avatar heinrichreimer commented on July 16, 2024

You must supply at least a background color, a title, a description and an image.
SimpleSlide is not meant to be used without arguments.

from material-intro.

Maxr1998 avatar Maxr1998 commented on July 16, 2024

Sure, but shouldn't there at least be some kind of check or default text, not just a plain crash?

from material-intro.

heinrichreimer avatar heinrichreimer commented on July 16, 2024

It throws an IllegalArgumentException saying that you must provide at least a background, title, description and image.

from material-intro.

Maxr1998 avatar Maxr1998 commented on July 16, 2024

Hm, ok. In my opinion that's not ideal, but ok. I don't want to meddle in your work, especially as it's so wonderful :)

from material-intro.

heinrichreimer avatar heinrichreimer commented on July 16, 2024

What should be the desired behavior?

from material-intro.

Maxr1998 avatar Maxr1998 commented on July 16, 2024

Well, if the id is null, just supply no text. Should I create a PR?

from material-intro.

heinrichreimer avatar heinrichreimer commented on July 16, 2024

I would appreciate that

from material-intro.

heinrichreimer avatar heinrichreimer commented on July 16, 2024

@Maxr1998 Your pull request contains only one small error. Would you please fix that, so that I can merge it?

from material-intro.

Maxr1998 avatar Maxr1998 commented on July 16, 2024

Oops, I'm terribly sorry. Didn't see the notifications the last days. Did you fix the issue yourself?

from material-intro.

heinrichreimer avatar heinrichreimer commented on July 16, 2024

No, I can't edit your pill request... Would be happy if you edit it

from material-intro.

Maxr1998 avatar Maxr1998 commented on July 16, 2024

I fixed it in my code, but I guess I also need to send a new pull request..

from material-intro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.