[BUG] The image refactor cause --disableFastRender not working about doit HOT 13 CLOSED

It can occasionally happen in prod build as well. I build 4 times and got 1 time error

from doit.

Can you share your params.toml or hugo.toml configurations? Specifically have you configured anything about params.image?

from doit.

image:
  # 缓存图片链接到本地
  cacheRemote : true
  # 图片缩放和优化
  optimise : true

I copied the configuration from master

from doit.

Can you provide a minimal reproduction? I cannot reproduce this issue on the exampleSite.

The error message is just saying that params.image has type string instead of map, which indicates that it might be a configuration error. I suspect somewhere in the config there is an image = "some/image.png" entry which is causing conflicts.

from doit.

I added image : "" into the seo.en.yaml, will it cause the conflict? as this is not 100% reproducible, so I need some time to make minimal project.

from doit.

I tried to log the data and debug the template, I found one interesting thing

Status	ScreenShot	Type
Success		Map
Fail		empty string
Fail		Map but recognize as String

So it seems the data is not recoginze instead of configuration problem

btw, I'm using YAML to config hugo

from doit.

How do you trigger the third case? What's the difference between the first case and the third case?

This might be an issue with Hugo...

from doit.

I try to rename image in image.html
from

{{- $cacheRemote := .CacheRemote | default site.Params.image.cacheRemote | default false -}}
{{- $optimise := .Optimise | default site.Params.image.optimise | default false -}}

to

{{- $cacheRemote := .CacheRemote | default site.Params.imageX.cacheRemote | default false -}}
{{- $optimise := .Optimise | default site.Params.imageX.optimise | default false -}}

and config the imageX in the params.yaml, then no issue found, so it still could be conflict. however, I searched the config in my site, only this image was configured. I have no idea to continue. could it conflict image with hugo?

from doit.

@HEIGE-PCloud nothing difference when trigger these 3 cases, just run and screenshot, all the configurations are the same. from my POV, it seems the configuration was changed in runtime in 3rd case, even though it read as map before, but the configuration was changed to String when process the image.html

from doit.

I think I figured out the RC, so I added below to my site as seo.en.yaml and seo.zh-cn.yaml

# Site SEO config
# 网站 SEO 配置
[seo]
  # image URL
  # 图片 URL
  image = "/images/Apple-Devices-Preview.png"
  # thumbnail URL
  # 缩略图 URL
  thumbnailUrl = "/images/screenshot.png"
  # Google 搜索结果中网站备用名字
  # alternate site name in Google search result
  # https://developers.google.com/search/docs/appearance/site-names#alternative
  # alternateName = ["Hugo DoIt"]

so whenever, I attach image field then it will be high possibility fail. If I remove the field, then nothing went wrong. But I have no idea, why the seo can override the image in params, it could be hugo issue

from doit.

The SEO config is under the params namespace https://github.com/search?q=repo%3AHEIGE-PCloud%2FDoIt%20params.seo&type=code

So it should be placed in params.yaml. Inside params.yaml, you should have both

image:
  cacheRemote: true
  optimise: true

seo:
  image: /images/Apple-Devices-Preview.png
  thumbnailUrl: /images/screenshot.png

I am not sure whether this is the RC though.

from doit.

I don't think Hugo actually supports arbitrary top level config keys... Not sure what it does when it sees one.

https://github.com/gohugoio/hugo/blob/7f3061723e3df064515fc57c183b06ed16f26b75/config/allconfig/allconfig.go#L98

from doit.

since the issue gone after the change, I think this should be RC. thx for support and sorry to raise false alarm

from doit.