Division by zero in /usr/src/grocytobring/index.php on line 44 about grocytobring HOT 5 CLOSED

@jacotec uh thanks - I just reviewed and merged your PR :) Thank you for that!

from grocytobring.

Hi @jacotec , thanks for your feedback. I will correct this and push a new version :)

from grocytobring.

I just commited the corrected version :)

from grocytobring.

@heig Oops, overlapped ... I've just created a pull request :-)
I've also corrected the missing use of plural quantity names ... maybe you'll merge mine with yours ;-)

from grocytobring.

@heig OK ... I've double checked, you did the easy workaround I posted in my issue.

Please feel free to merge my PR. The "easy way" does not consider purchase units.

Example:
Item: Water
Unit: Bottle
Purchase Unit: Box (12 bottles per Box)
Minimum stock: 5 bottles

With the easy fix this will result in "2 Box" on the shopping list in Bring when the stock drops to 3 bottles.

With my PR you'll get "1 Box" on the list as the amount to shop is calculated using the shopping quantity conversion and unit name.
Also it will use the plural "boxes" if the quantity is larger than 1.

from grocytobring.