Giter Club home page Giter Club logo

Comments (2)

cuu508 avatar cuu508 commented on July 18, 2024 1

I've now fixed the URL validation code to allow URLs with just hostname and no domain or tld. http://ntfy/healthcheck should work now.

I did not tie the URL validation logic to the INTEGRATIONS_ALLOW_PRIVATE_IPS setting, because private IPs and "naked hostnames" are not the same thing:

  • A normal-looking URL can resolve to a private IP: example.org A 192.168.0.1.
  • And, conversely, when using a private DNS, a "naked hostname" can resolve to a public IP: ntfy A 1.2.3.4

from healthchecks.

cuu508 avatar cuu508 commented on July 18, 2024

Thanks for the report.

We have the INTEGRATIONS_ALLOW_PRIVATE_IPS setting. It this setting is enabled, it would make sense to also relax URL validation rules. I'll see what can be done here.

In the meantime, as a workaround, you can use the IP address instead of the hostname in the URL.

from healthchecks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.