Giter Club home page Giter Club logo

Comments (9)

fsteeg avatar fsteeg commented on June 1, 2024

Deployed to test: https://test.lobid.org/gnd/1083009273

from lobid-gnd.

acka47 avatar acka47 commented on June 1, 2024

I am not that happy with this solution. I don't think that we should link to the JSON other than we already do in the top right corner. I'd rather leave out the field completely in the HTML or collapse the labels as written in the first comment.

from lobid-gnd.

fsteeg avatar fsteeg commented on June 1, 2024

Collapsing is a bit more involved, would require some restructuring of the implementation (the whole table is just a flat list internally, so I'd have to introduce some way to distinguish the separate field groups). I'd expect users to be confused if they find an entity via its variant name but don't see any variant names in the details.

How about adding the remaining variant names to a popup on the ... icon istead of linking to the JSON?

from lobid-gnd.

ChristophEwertowski avatar ChristophEwertowski commented on June 1, 2024

I would be fine with a popup but then there should be more space between the points of the icon. My eyes first saw little "-".

from lobid-gnd.

fsteeg avatar fsteeg commented on June 1, 2024

Updated on test: https://test.lobid.org/gnd/1083009273

from lobid-gnd.

ChristophEwertowski avatar ChristophEwertowski commented on June 1, 2024

Intuitively I clicked on the plus but probably that's just my brain. Hovering works fine. +1

from lobid-gnd.

acka47 avatar acka47 commented on June 1, 2024

It's not just your brain. "+" commonly means expand so we should use another icon (or another approach).

from lobid-gnd.

fsteeg avatar fsteeg commented on June 1, 2024

Updated with another ellipsis icon: https://test.lobid.org/gnd/1083009273

from lobid-gnd.

acka47 avatar acka47 commented on June 1, 2024

+1

from lobid-gnd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.