[BUG] Assets Themekit does not upload about shopify-packer HOT 9 CLOSED

@Steda-dev can confirm fonts not being copied to dist as assets in v2.1.5, but in previous packer version they did, can you help @hayes0724 please?
My folder structure is src/fonts, and in previous versions packer automatically copied them to assets, maybe something changed?

from shopify-packer.

I’m facing this same exact problem

from shopify-packer.

@yashghelani @Steda-dev It should not upload any files unless they are liquid, when using start/watch the files are served locally and updated with hmr. For hmr to work the script and style tags snippet needs to have local ip. If you run watch (vs start) without having this uploaded to Shopify you will not see updates. I use start almost every time to make sure, watching is only good for temporary breaks (ex you just ran start recently).

Not uploading non liquid files is expected behavior, Are you not seeing changes happen after editing non liquid files?

1. When using watch do any changes happen after editing a file? ex. adding alert message on theme.js
2. Have you tried start?
3. If you run deploy it will upload all the files but hmr will not work (start/watch) you would see your previous changes on the first load. This is because deploy makes a production version using Shopify's CDN and start/watch need local address to avoid using CDN.

When you are having this issue can you take a screenshot of the network tab with the layout.theme.js file selected?

Also I have noticed a similar issue when switching to start/watch after running a deploy, it's solved by deleting the dist folder before running any commands. In v2.1.9 I changed the webpack cleans the dist folder so this should no longer be needed.

from shopify-packer.

@hayes0724 i managed to work around with fonts by manually copy them from src/fonts to src/assets and then they are uploaded, can you please confirm this is correct process? thanks

from shopify-packer.

@marioloncarek You can/should add fonts to the assets folder. The src/assets folder is flattened during build so if you use src/assets/fonts it will be moved automatically to dist/assets

from shopify-packer.

@hayes0724 thank you! if that is the case i must say everything works correctly for me, sorry for misunderstanding

from shopify-packer.

@Steda-dev @yashghelani Are you still having issues with this?

from shopify-packer.

@hayes0724 I think my issue was with the version of node I was using, i.e. v16. I’m using the LTS version now and the npm version that comes with it. That has solved all the issues for me. I’m afraid I cannot provide more information about the issue I was facing with v16 as I didn’t get time to test and quickly downgraded to the LTS version. If I can be of help in any other way by providing any information, let me know. I’ll be happy to help.

from shopify-packer.

I still have this issue..
Does not upload the js files in the assets folder after the file is changed while running the yarn start command.
The changed file is visable in the dist folder.

Steps to reproduce the behavior:

• packer watch
• change the js file
• does not upload the file, but changes are made in the dist folder
• packer deploy
• now it works

System:

• Windows 10
• Node Version 12.22.9
• NPM Version 6.14.15
• Browser: Google Chrome

Packer:

• Version v2.2.0

from shopify-packer.