Comments (5)
@tariky this error occurs because of the script tag isn't closed correctly. Just find the tag (I think it was inside theme.liquid at the bottom) and close it correctly.
from shopify-packer.
@tariky this error occurs because of the script tag isn't closed correctly. Just find the tag (I think it was inside theme.liquid at the bottom) and close it correctly.
I tried that, there is none script tags in theme.liquid.
from shopify-packer.
@tariky Check the version (and post in issue) of packer and packer-blank-theme that you are using. Also the steps needed to recreate, examples:
- started a new project with packer init
- worked on an existing project/website
- any commands or files changed
from shopify-packer.
@tariky this error occurs because of the script tag isn't closed correctly. Just find the tag (I think it was inside theme.liquid at the bottom) and close it correctly.
I tried that, there is none script tags in theme.liquid.
If you don't find the script tag in your theme.liquid maybe you have not added it yet. Make sure you added this to the bottom of your theme.liquid file:
{%- render 'script-tags' -%}
{%- render 'style-tags' -%}
I use render instead because include was flagged as deprecated by shopify:
https://shopify.dev/docs/themes/liquid/reference/tags/deprecated-tags#include
Reference in Documenation:
https://github.com/hayes0724/shopify-packer#script-and-style-tags
from shopify-packer.
Source of the issue was the body tag, class was not closed:
<body class="template-{{ template.name }}{%- if template.suffix -%}__{{ template.suffix }}{%- endif -%}>
missing " at the end.
Thanks for the feedback, this is fixed in packer theme v1.0.9
from shopify-packer.
Related Issues (20)
- [FEAT] script-tags for pages HOT 1
- Question: Using section scripts? HOT 1
- [BUG] ERROR in Conflict: Multiple assets emit different content to the same filename HOT 2
- [BUG] Style-tags.liquid not loading product.css
- [FEAT] Shopify CLI to replace theme kit HOT 10
- [BUG] Packer Build - Conflict: Multiple assets emit different content to the same filename HOT 2
- [BUG] Packer is not accepting Themekit access App Password HOT 2
- z-index values are getting flattened to 1 or 2. Does anyone know which of css-loader, style-loader, sass-loader, and postcss-loader could be responsible for this? HOT 2
- [BUG-Critical] packer build keeps failing on node enviroment HOT 1
- Facing issue HOT 3
- Packer works with NVM, but not with Volta. Issues with various webpack loaders when installed through Volta HOT 1
- [BUG] style.css.liquid in assets breaks watcher HOT 1
- Assertion failed: (thread_id_key != 0x7777), function find_thread_id_key, file coroutine.cc, line 134.[BUG] HOT 4
- [BUG] Chalk v5 does not allow 'require' breaking new installations HOT 5
- [BUG] packer start isn't updating the changes on the dev theme.. HOT 2
- [Bug] `packer start` : have it watch and upload all changed files, not just *some* HOT 1
- Global installation of packer fails on installation of @shopify/themekit [BUG] HOT 1
- [BUG] Cannot change theme source styles directory
- Conflicting name with Hashicorp's Packer
- Grahhh
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shopify-packer.