Giter Club home page Giter Club logo

Comments (5)

batjeciftci avatar batjeciftci commented on May 24, 2024

@tariky this error occurs because of the script tag isn't closed correctly. Just find the tag (I think it was inside theme.liquid at the bottom) and close it correctly.

from shopify-packer.

tariky avatar tariky commented on May 24, 2024

@tariky this error occurs because of the script tag isn't closed correctly. Just find the tag (I think it was inside theme.liquid at the bottom) and close it correctly.

I tried that, there is none script tags in theme.liquid.

from shopify-packer.

hayes0724 avatar hayes0724 commented on May 24, 2024

@tariky Check the version (and post in issue) of packer and packer-blank-theme that you are using. Also the steps needed to recreate, examples:

  • started a new project with packer init
  • worked on an existing project/website
  • any commands or files changed

from shopify-packer.

mrpacman101 avatar mrpacman101 commented on May 24, 2024

@tariky this error occurs because of the script tag isn't closed correctly. Just find the tag (I think it was inside theme.liquid at the bottom) and close it correctly.

I tried that, there is none script tags in theme.liquid.

If you don't find the script tag in your theme.liquid maybe you have not added it yet. Make sure you added this to the bottom of your theme.liquid file:

 {%- render 'script-tags' -%}
 {%- render 'style-tags' -%}

I use render instead because include was flagged as deprecated by shopify:
https://shopify.dev/docs/themes/liquid/reference/tags/deprecated-tags#include

Reference in Documenation:
https://github.com/hayes0724/shopify-packer#script-and-style-tags

from shopify-packer.

hayes0724 avatar hayes0724 commented on May 24, 2024

Source of the issue was the body tag, class was not closed:

<body class="template-{{ template.name }}{%- if template.suffix -%}__{{ template.suffix }}{%- endif -%}>

missing " at the end.

Thanks for the feedback, this is fixed in packer theme v1.0.9

from shopify-packer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.