Comments (3)
i just git ignored the default packer.env.json and config.json and created a sample.packer.env.json for the devs. This way they can just use the sample file and create their own locally. No need to mess around with local env variables.
from shopify-packer.
All packer values can be loaded from env values, the config file is not needed if your using env (example CI deploys). This needs to be documented better. Although not required, packer.config.json
is ignored by default in packer theme.
@mrpacman101 This is the preferred method that I use. It's best to let each developer keep a local copy and have a sample file for them to populate.
The env values are located in src/env/packer-env.schema.js
for reference (this should be added to the docs for CI use)
const commonPaths = require('../config/common-paths');
module.exports = {
...commonPaths,
// The environment variable key which contains the name of the environment
// Packer is running in
'env.keys.name': 'PACKER_ENV',
// The environment variable key which contains the myshopify.com URL to your
// Shopify store
'env.keys.store': 'PACKER_STORE',
// The environment variable key which contains the API password generated from
// a Private App
'env.keys.password': 'PACKER_PASSWORD',
// The environment variable key which contains the ID of the theme you wish to
// upload files to
'env.keys.id': 'PACKER_ID',
// The environment variable key which contains a list of file patterns to
// ignore, with each list item separated by ':'
'env.keys.ignore': 'PACKER_IGNORE',
// The environment variable key which contains a list of file patterns to
// allow deployment to live themes
'env.keys.live': 'PACKER_LIVE',
};
from shopify-packer.
@hayes0724 thank you, that helps a ton.
from shopify-packer.
Related Issues (20)
- [FEAT] script-tags for pages HOT 1
- Question: Using section scripts? HOT 1
- [BUG] ERROR in Conflict: Multiple assets emit different content to the same filename HOT 2
- [BUG] Style-tags.liquid not loading product.css
- [FEAT] Shopify CLI to replace theme kit HOT 10
- [BUG] Packer Build - Conflict: Multiple assets emit different content to the same filename HOT 2
- [BUG] Packer is not accepting Themekit access App Password HOT 2
- z-index values are getting flattened to 1 or 2. Does anyone know which of css-loader, style-loader, sass-loader, and postcss-loader could be responsible for this? HOT 2
- [BUG-Critical] packer build keeps failing on node enviroment HOT 1
- Facing issue HOT 3
- Packer works with NVM, but not with Volta. Issues with various webpack loaders when installed through Volta HOT 1
- [BUG] style.css.liquid in assets breaks watcher HOT 1
- Assertion failed: (thread_id_key != 0x7777), function find_thread_id_key, file coroutine.cc, line 134.[BUG] HOT 4
- [BUG] Chalk v5 does not allow 'require' breaking new installations HOT 5
- [BUG] packer start isn't updating the changes on the dev theme.. HOT 2
- [Bug] `packer start` : have it watch and upload all changed files, not just *some* HOT 1
- Global installation of packer fails on installation of @shopify/themekit [BUG] HOT 1
- [BUG] Cannot change theme source styles directory
- Conflicting name with Hashicorp's Packer
- [BUG] Cannot GET / - https://127.0.0.1:3001/ doesn't work + Packer start doesn't watch SCSS changes HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shopify-packer.