Giter Club home page Giter Club logo

Comments (2)

holymp2006 avatar holymp2006 commented on May 24, 2024 1

I really appreciate the suggestions.
However, the errors have more to do with webpack config, than how I set up the src directory.

I solved it by npm installing file-loader, and adding the following rules to the prod.config.js file:

{
   test: /\.(woff(2)?|png|svg|jpg|gif|ttf|otf|eot)$/,
   use: ["file-loader"],
 }

Thanks for an awesome package.

from shopify-packer.

hayes0724 avatar hayes0724 commented on May 24, 2024

On Shopify all files are flat and use CDN so you can't link to an image in css using url(../images/fancybox_loading.gif)

See Styles with Liquid for more information

Typically if you need an image inside the stylesheet you have a few options:

  1. add to theme.scss.liquid using liquid, ex: url({{ 'fancybox_loading.gif' | asset_img_url }})
  2. use the library CDN for css: <link rel="stylesheet" type="text/css" href="jquery.fancybox.min.css">
  3. use the dist/css for the package. Note this is dependent on the library you are using
yarn add @fancyapps/fancybox
  1. You could make the above URL's work while in development mode by adding the proper directory and settings to file loader but you would still need to do one of the 3 solutions above to deploy on Shopify.

I typically use option 3 (if it's supported), otherwise option 1 or 2.

@import "~@fancyapps/fancybox/dist/jquery.fancybox.css"

This is a common issue with Shopify, especially when working with prebuilt HTML.

from shopify-packer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.