Giter Club home page Giter Club logo

Comments (7)

Simn avatar Simn commented on May 29, 2024

I'm sure it's from this change: 2935767

I have to get the get/set properties under control. Is there something special about this method? Could you post its XML?

from dox.

dpeek avatar dpeek commented on May 29, 2024

Why are we doing so much work in the template? I'd rather do it when processing and pass the needed info to the template.

from dox.

Gama11 avatar Gama11 commented on May 29, 2024

@Simn Nothing special at all, in fact, it seems to happen for all methods.

<replaceColor public="1" set="method" line="1010">
            <f a="Color:NewColor:?FetchPositions" v="::false">
                <x path="Int"/>
                <x path="Int"/>
                <x path="Bool"/>
                <c path="Array"><c path="flixel.util.FlxPoint"/></c>
            </f>
            <haxe_doc>* Replaces all pixels with specified Color with NewColor pixels
     * @param   Color               Color to replace
     * @param   NewColor            New color
     * @param   FetchPositions      Whether we need to store positions of pixels which colors were replaced
     * @return  Array replaced pixels positions</haxe_doc>
        </replaceColor>

I did generate the docs + the xml with haxe 3.1.3 though, does that matter?

from dox.

Simn avatar Simn commented on May 29, 2024

@dpeek: That's not so easy because we're working with the CType data, which we can't extend in a trivial way. I have a Haxe issue open to address this problem: HaxeFoundation/haxe#3471

Of course we could instead have some API method for this. In fact, I'm not sure what/if I was thinking when I made that template. :)

@Gama11: Can you try updating hxtemplo? There was some weird issue related to order of switch cases.

from dox.

Gama11 avatar Gama11 commented on May 29, 2024

@Simn That fixed it - mostly. Still seems to fail for inlined functions:

Previously:

Now:

<resetFrameBitmapDatas public="1" get="inline" set="null" line="1265">
            <f a=""><x path="Void"/></f>
            <haxe_doc>* Helper function for reseting precalculated FlxFrame bitmapdatas.
     * Useful when _pixels bitmapdata changes (e.g. after stamp(), FlxSpriteUtil.drawLine() and other similar method calls).</haxe_doc>
        </resetFrameBitmapDatas>

from dox.

Simn avatar Simn commented on May 29, 2024

I'd expect the same get/set combination from an inline variable, which would make this indistinguishable. I guess we can rely on the type in this case because there's no such thing as an inline function variable, but it's still a bit bad...

from dox.

Simn avatar Simn commented on May 29, 2024

I've "fixed" it.

from dox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.