Update HawtioConfig type to match `@hawtio/react` hawtconfig.json model about hawtio-operator HOT 4 CLOSED

@phantomjinx I found that there is online.consoleLink option in hawtconfig.json for hawtio-operator, which is not present in hawtio/react. Do you know if it's used in hawtio-online? If it's not dead code but isn't utilised in hawtio-online, it might be something we miss.

from hawtio-operator.

OK, I learned hard that the HawtioConfig type here doesn't necessarily reflect the type definition provided by @hawtio/react. HawtioConfig generally only needs type definitions for what the operater uses. Ultimately, what is really needed is the online.consoleLink for the operator, and the rest (even About and Branding) are not really needed here.
(@phantomjinx That answers my own question above. It's ok that we don't observe the usages of online.consoleLink anywhere else, since hawtio-operator is where the option is consumed.)

That concludes this task of syncing the definitions between @hawtio/react and hawtio-operator is not needed.

from hawtio-operator.

In addition, the recent changes I added to hawtconfig.json at @hawtio/react hawtio/hawtio-next#646 uses union type boolean | string[]. JS/TS is fine to handle union types but Go isn't. That makes it really hard to encode the type definitions in the operator, so ultimately we should avoid using union types.

But for now, I don't think the operator will use the newly added option jmx.workspace, and it really shouldn't as the operator should be agnostic to the configurations of specific Hawtio plugins, even if it's as basic as JMX.

from hawtio-operator.

I'm closing it as 'Wont Do'.

from hawtio-operator.