Comments (2)
So, the main reason we did it was to follow the DeepSurv implementation. It is not really the partial log-likelihood, but an approximation that is simpler to implement. The approximation is correct as long as there are no tied observation times (which is generally a problem in Cox regression), and with few tied events the approximation should be fine. When there are tied observations, only one of them will get the correct likelihood contribution. Although there is no formal theoretical justification for this approximation, the fact that we are computing it over random subsets (batches used for SGD) makes the ordering of the tied observations random, which should decrease the bias. Through empirical studies we have also found that the approximation has little effect on prediction (though we have not really studied the estimated parameters). A formal study of this would have been interesting as a contribution to the literature on the Cox partial likelihood with tied event times.
Thank you for the question, as I think it is an important one, and I hope the answer was satisfactory.
I think a good contribution to this package would be to add loss function for the Cox partial log-likelihoods with Breslow and Effron approximations for the tied events.
from pycox.
Thanks for your quick (and satisfactory) reply. Basically this means that as long as the rate of ties is low everything should be fine. Should I reimplement the loss w/ Breslow/Effron I will definitely let you know and/or open a PR.
Thanks!
from pycox.
Related Issues (20)
- Issue in function cox_time.py HOT 1
- L1 and L2 penalty coxph HOT 1
- AssertionError: assert durations.shape[0] == surv.shape[1] == surv_idx.shape[0] == events.shape[0]
- METABRIC Covariates Subset HOT 1
- AttributeError: 'Series' object has no attribute 'is_monotonic' HOT 18
- about hazard value! HOT 2
- Reproduction of the results in JMLR19 paper HOT 1
- Calculating Estimated Population Survival Curve HOT 4
- Some question about the result of deephit_competing_risks HOT 2
- AttributeError: 'DeepHitSingle' object has no attribute 'state_dict' HOT 1
- ValueError: cannot convert float NaN to integer HOT 1
- Softmax layer and residual connections in DeepHitSingle model HOT 1
- _initialization of _internal failed
- TypeError: forward() missing 1 required positional argument: 'events'
- ValueError: cannot convert float NaN to integer HOT 1
- A model to add
- Auto-encoder pycox implementation for 3D images instead of tabular data
- performance for ordinal categorical covariates
- what kind of model in pycox works for sequential patterns
- Newton-Raphson optimization
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pycox.