Comments (4)
hsyl20
commented on August 17, 2024
I have added the missing instances (cf 971cfd8) and released haskus-utils-variant-2.6.1
You have to add Eq1 instances for your functors (ValF, EmptyNoteF) similarly to what I've done in the test here: 971cfd8#diff-098a4303323c6f5065eca85c4601d802R62
from packages.
pcarbonn
commented on August 17, 2024
Terrific ! You are a genius.
When I upgrade from 2.4 to 2.6, I get an error message because of AlgVariantF has an extra parameter "r" in the 3rd place since 2.5. Apparently, I have to duplicate the type of the result of the algebra.
However, documentation does not seem to be updated.
from packages.
hsyl20
commented on August 17, 2024
Thanks for your comment! It forced me to give more thoughts to what we are doing with those algebras. Hence I have completely removed the ad-hoc AlgVariantF/EADT things and replaced them with AlgebraC,Algebras, fromAlgebraC and fromAlgebras as briefly documented here
I have added some EADT tests that also show how to use them.
I still need to update the documentation and to make a release but if you can give me your feedback on this approach beforehand it would be better (less releases on Hackage...). Thanks!
from packages.
pcarbonn
commented on August 17, 2024
Salut !
I find the approach very interesting, but I fail to see whether the tuple
of Algebras could be a limitation. Will it have the flexibility to support
the 3 approaches of Constructor removal
<https://docs.haskus.org/eadt/constructor_removal.html>, for example ? I
could see it work for fixed-input/fixed-matches, but not for the other
cases. Or am I missing something ?
PC
…On Tue, Mar 5, 2019 at 5:09 PM Sylvain Henry ***@***.***> wrote:
Thanks for your comment! It forced me to give more thoughts to what we are
doing with those algebras. Hence I have completely removed the ad-hoc
AlgVariantF/EADT things and replaced them with AlgebraC,Algebras,
fromAlgebraC and fromAlgebras as briefly documented here
<https://github.com/haskus/packages/blob/5f6b5f0b2019442989681bab60b23e1c9d3ebf9b/haskus-utils-variant/src/lib/Haskus/Utils/VariantF.hs#L350>
I have added some EADT tests
<https://github.com/haskus/packages/blob/5f6b5f0b2019442989681bab60b23e1c9d3ebf9b/haskus-utils-variant/src/lib/Haskus/Utils/EADT.hs#L80>
that also show how to use them.
I still need to update the documentation and to make a release but if you
can give me your feedback on this approach beforehand it would be better
(less releases on Hackage...). Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAa5aY79A6Xi8Je6MB5mYr0Pg5jZTpJ7ks5vTpbOgaJpZM4bcurQ>
.
from packages.
Related Issues (20)
- haskus-binary-1.4 not compilable with primitive-0.7.0.0 HOT 3
- Use asm foreign file in Haskus.Memory.Embed
- Replace happstack-server with wai HOT 1
- No release for Excepts on hackage HOT 1
- haskus-utils-types build failures. HOT 1
- haskus-utils does not build with haskus-utils-variant-3.0 HOT 3
- Excepts ergonomics HOT 9
- Build errors as a dependency during `stack build` HOT 7
- MonadBaseControl instance? HOT 7
- Mutually recursive EADTs HOT 5
- Fails to build with GHC 9.2.1 HOT 2
- Unsoundness issues when using `forM` with `throwE` in `Excepts` HOT 2
- No Eq instance for Haskus.Utils.Variant.VEither HOT 3
- Fails to check doctests HOT 6
- haskus-utils-variant does not build with GHC-9.6 HOT 1
- docs subdomain dead ? HOT 2
- build on 9.2+ HOT 6
- Pattern synonyms do not support linear fields HOT 2
- System: use our own CPIO implementation
- Migrate and update old user manual
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from packages.