Support post compile hook about heroku-buildpack-elixir HOT 10 CLOSED

@chrismccord won't that mean we would need node.js installed too? (https://github.com/ddollar/heroku-buildpack-multi).

\cc: @ericmj

from heroku-buildpack-elixir.

Just an FYI that Heroku Buildpacks have changed a bit. You no longer need the multi-buildpack to specify a build pipeline. Instead, specify each buildpack individually with the following CLI:

$ heroku buildpacks:set https://github.com/HashNuke/heroku-buildpack-elixir.git
$ heroku buildpacks:set https://github.com/heroku/heroku-buildpack-nodejs

Regarding brunch asset compilation, here's how they do it in the official Ruby/Rails buildpack.

from heroku-buildpack-elixir.

Should we automatically run a post_compile / post_compile.sh file in your root directory or should we take the file from a post_compile option in elixir_buildpack.config?

/cc @josevalim

from heroku-buildpack-elixir.

I thought the plan was to not support hooks. What changed? :)

from heroku-buildpack-elixir.

At work, I was working with a non-Heroku deployed app where the compilers option in mix.exs was used to add a :frontend compiler so that everytime the app is started or compiled, the frontend too gets compiled.

Curious how a post compile hook will help on Heroku since we depend on mutl-buildpack for asset compilation.

from heroku-buildpack-elixir.

At work, I was working with a non-Heroku deployed app where the compilers option in mix.exs was used to add a :frontend compiler so that everytime the app is started or compiled, the frontend too gets compiled.

The problem is that you might not want to compile assets on every compilation or app start so a Heroku specific compilation step is very useful.

Curious how a post compile hook will help on Heroku since we depend on mutl-buildpack for asset compilation.

Not sure what you are asking here, as long as the node buildpack runs before the elixir buildpack it will work.

from heroku-buildpack-elixir.

@ericmj I meant to ask what the use case was for the post-compile hook. I remember there was this discussion earlier in another issue and that that issue was closed.

Sorry read your comment in bed and forgot to reply the other day.

from heroku-buildpack-elixir.

phoenixframework/phoenix#835

from heroku-buildpack-elixir.

@ericmj 👍 thanks for linking. Got it now ~!

from heroku-buildpack-elixir.

Yaaay ~!

from heroku-buildpack-elixir.