Giter Club home page Giter Club logo

Comments (8)

ericmj avatar ericmj commented on August 23, 2024 1

We should close this issue and let users decide what they prefer, especially since the flag does different things for different OTP versions.

from heroku-buildpack-elixir.

ericmj avatar ericmj commented on August 23, 2024

What does it do and what are the defaults?

from heroku-buildpack-elixir.

josevalim avatar josevalim commented on August 23, 2024

+K enables kernel polling. Which may slightly degrade performance but it works great for chunking, long lived connections (be it for slow clients or waiting on the server and so on) and so on.

+A 100 is the size of the async pool (default is 10). Interacting with the file system usually goes through the async pool. Increasing the pool increasing boot time but it will likely increase performance for the plug static layer.

We could benchmark to be double sure.

from heroku-buildpack-elixir.

ericmj avatar ericmj commented on August 23, 2024

Okay, thanks for the information. Lets start with allowing you to set erlang flags through elixir_buildpack.config. If benchmarks show that changing the flags will improve performance we can change the defaults. Sounds good?

Would also like @HashNuke's opinions before signing off.

from heroku-buildpack-elixir.

HashNuke avatar HashNuke commented on August 23, 2024

@ericmj +1 for making it configurable.
@josevalim are there any more interesting flags we could use?

What code should we be using for benchmarking?

On Tue, Jan 20, 2015 at 8:11 PM, Eric Meadows-Jönsson <
[email protected]> wrote:

Okay, thanks for the information. Lets start with allowing you to set
erlang flags through elixir_buildpack.config. If benchmarks show that
changing the flags will improve performance we can change the defaults.
Sounds good?

Would also like @HashNuke https://github.com/HashNuke's opinions before
signing off.


Reply to this email directly or view it on GitHub
#25 (comment)
.

from heroku-buildpack-elixir.

ericmj avatar ericmj commented on August 23, 2024

I've been using this on hex_web for a while with no issues https://github.com/hexpm/hex_web/blob/master/Procfile.

I think we should set the default Procfile to set the flags and document that we recommend setting them. The phoenix buildpack should probably do the same. /cc @gjaldon

from heroku-buildpack-elixir.

gjaldon avatar gjaldon commented on August 23, 2024

Copy that @ericmj. I'll apply the configurable erlang flags too and apply the suggested flags as defaults.

from heroku-buildpack-elixir.

AndrewDryga avatar AndrewDryga commented on August 23, 2024

In OTP 21 those flags are deprecated (kernel polling is already on by default) and +A is replaced with dirty IO schedulers. I'm not sure should we increase default value of 10 or not though.

from heroku-buildpack-elixir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.