Thanks about home HOT 7 CLOSED

oh, thanks a lot. I have never forked any repo. Guess one more thing learned. pr done. feel free to comment, reject, or anything you see fit

from home.

Sure, I'll test this locally. 🔥

that is terrible code, discard it. i have learned a lot. thank you though

from home.

Hi @xunxdd,

I'm glad to see your version of portfolio. It's really tempting. 😃 I'll probably showcase your version in my readme.
Yess, setting an active tab in navigation bar would be a nice contribution. ✨

Best,
Hashir

from home.

Thanks. @hashirshoaeb . I tried to do a pr, however found that I am not permissioned.
`

   const sections = document.querySelectorAll(".target-section");
   sections.forEach(function(current) {
    const sectionHeight = current.offsetHeight;
    const sectionTop = current.offsetTop - 50;
    const sectionId = current.getAttribute("id");
    const pos = navBottom - scrollPosition;
   /* If our current scroll position enters the space where current section 
    * on screen is, set active section
    */
    if (pos > sectionTop && pos <= sectionTop + sectionHeight) {
      setActive(sectionId);
    } `

I basically add a class to each relevant section and onScroll did the above, it is also done here

https://github.com/xunxdd/portfolio/blob/master/src/components/Navbar.jsx

Though since your menu is light-gray colored, the active menu style is not very obvious, so the pr is probably not necessary anyway

Please let me know if the above is the right approach though. I'd appreciate. Thanks

from home.

hmm, seems like you have not forked this repo.

1. fork this repo.
2. clone your forked repo into your computer.
3. create a branch.
4. make changes in that branch.
5. push the branch to your forked repo.
6. create a pull request.

learn more from, here https://www.neonscience.org/resources/learning-hub/tutorials/version-control-github

Feel free to ping me via email or linkedin, if you face any issues.

Best,
Hashir

from home.

Sure, I'll test this locally. 🔥

from home.

Adding your portfolio link in my Readme.

from home.