Variable declaration error in `for` expression about vscode-terraform HOT 7 CLOSED

The underlying issue here is, that { for ... } will result in an object, but the for_each meta-argument accepts a map or a set of strings. Passing objects to for_each is still supported for backwards compatibility reasons, but should generally be avoided.

A workaround is to wrap the expression in a tomap call:

resource "local_file" "foobar" {
  for_each = tomap({ for i in var.foobar : i.name => i })

  content  = each.value.name
  filename = "${path.module}/${each.value.name}.txt"
}

This will get rid of the error and fix the completion and go to definition for var.foobar.

The validation error here is still worth fixing though, because it is a valid Terraform configuration. In an ideal world, we would raise a warning instead and allow you to apply a quickfix.

from vscode-terraform.

It doesn't always pick up on that as an error. I have that type of code all over the place, and not all show as errors.

I disagree that this should even raise a warning. If terraform validate allows it then so should the vscode extension. In my opinion there shouldn't be a difference between the two.

from vscode-terraform.

We just released a new version 2.29.5. This fixes the reported bug. The update should appear automatically in VS Code.

Thank you for the report @pawwe

In case you experience any different validation related bug, please do let us know through a new issue.

from vscode-terraform.

I'm the same.

from vscode-terraform.

Thanks for the report! I can reproduce the issue with the snippet you provided.

from vscode-terraform.

That makes sense. Thanks for looking into it!

from vscode-terraform.

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

from vscode-terraform.