Comments (8)
Thanks for opening this, @radeksimko. Is this causing problems in the LS?
from terraform-exec.
@kmoe I'm not aware of it causing problems to the users, at least nobody filed an issue. I was able to reproduce it in one test in LS though.
I assume that the reason it's (probably) not affecting users is because they'd have to be running many commands at the same time - which some of them probably do, but we limited that significantly per hashicorp/terraform-ls#391 - and the execution would need to overlap in a particular (split-second) moment.
I mean - race conditions are just hard to reproduce in general. 🤷🏻♂️
from terraform-exec.
There are valid terraform-exec use cases involving parallel execution outside the LS, so this is the highest priority bugfix for tfexec right now, but active LS issues would raise it to "critical".
There shouldn't be any other test failures with 0.12.0, or rather, 0.12.30 (a support policy we should be clearer about). Filing and fixing these will be done as part of investigating the race failures.
from terraform-exec.
There shouldn't be any other test failures with 0.12.0, or rather, 0.12.30
As far as I can remember these were related to some of the CLI flag changes (in master
/main
), so I think that is expected as these tests rely on an external source, which itself is a moving target.
I'm not sure how/whether that affects the support policy. I assume we intend to support all versions of Terraform (on best-effort basis), but do we also intend to offer such support in all versions of terraform-exec
? That seems like a promise hard to uphold.
from terraform-exec.
Just ran into another race condition in some LS tests:
https://github.com/hashicorp/terraform-ls/pull/448/checks?check_run_id=2225193121#step:10:31
The trace suggests it's a different one, but I haven't looked into it too deeply.
from terraform-exec.
Actually this one is pretty much 100% (3 out of 3 attempts) reproducible with go test -race
(on LS side at least) ^ which means it's likely to be attributed to some of the recent dependency updates. 👀
from terraform-exec.
The last mentioned race condition will is fixed in go-getter
1.5.3 via hashicorp/go-getter#315 but the other race conditions are AFAIK still present and likely unrelated.
from terraform-exec.
This was addressed by the amazing @lornasong in #299 🎉
go test ./... -race -count=5 -timeout=30m
? github.com/hashicorp/terraform-exec/internal/version [no test files]
ok github.com/hashicorp/terraform-exec/tfexec 17.355s
ok github.com/hashicorp/terraform-exec/tfexec/internal/e2etest 907.986s
? github.com/hashicorp/terraform-exec/tfexec/internal/testutil [no test files]
from terraform-exec.
Related Issues (20)
- Support for `terraform state show`
- Pass through environment variables when `SetEnv()` is used
- TF_WORKSPACE not parsed for empty Cloud block HOT 2
- follow terraform apply HOT 7
- Add functions that run Terraform commands with `-json` flag HOT 1
- Init -migrate-state HOT 6
- stderr is empty HOT 5
- Support `state list` HOT 2
- Does this library provide a way to gracefully shutdown
- Use terraform-json StateOutput for Output method return value
- Consider supporting `terraform test` HOT 1
- Failure to unmarshall checks list with Terraform 1.6
- Init error return
- Support -generate-config-out option for terraform plan HOT 1
- Consider adding show option to configure JSON decoding
- Make UseJSONNumber the default
- Unable to set log level without writing to file HOT 1
- Passing In Variables At Runtime
- Terraform Apply Command Looking For AZ CLI
- Support `terraform init` JSON output (coming soon)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-exec.