Giter Club home page Giter Club logo

Comments (2)

jeffwecan avatar jeffwecan commented on August 9, 2024 2

I'm definitely down with using the module's output variables to programmatically get at the role ARN when appropriate. To clarify the issue's description:

  • It isn't a matter of the role name being unknown post-deploy, its a matter of the ARN not being known before invoking terraform apply.
  • Additionally, it is conceivable that the role ARN would change on subsequent deployments. For instance, if the cluster_name variable was modified.

That said, this issue was filed to ensure the idea wasn't completely misguided (and to abide by per the repo's contributing guidelines). I totally intend to try my hand at a PR for this fella! 😅

from terraform-aws-vault.

brikis98 avatar brikis98 commented on August 9, 2024

The module does return the IAM ARN info as output variables, so you shouldn't have to hard-code them: https://github.com/hashicorp/terraform-aws-vault/blob/master/modules/vault-cluster/outputs.tf#L21-L27.

That said, this feature would likely be useful for a number of reasons, so I'm in favor of it. It should be straightforward to add an iam_role_name input variable, set to an empty string by default, and to name the IAM role using that variable if it's non-empty or var.name otherwise.

PRs welcome!

from terraform-aws-vault.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.