Giter Club home page Giter Club logo

Comments (6)

harm-less avatar harm-less commented on August 14, 2024 2

Well, that's embarrassing... Please update to `0.2.3`` and see if that works.

I forgot trackedElements was a function and needed to be called as such.

from angular-sticky.

harm-less avatar harm-less commented on August 14, 2024 1

I fixed it, here you go. Thanks for spotting this.

from angular-sticky.

harm-less avatar harm-less commented on August 14, 2024 1

You're welcome, thanks for the issue report again.

The age old indent war, haha. Even though it might be more popular, I feel with a bit more indentation it's easier to read. So that's why I decided to stick with that.
But one advantage of tabs is that you can tell your IDE how to interpret a tab. So if you prefer 2 spaces, you can simply pretend ;)

from angular-sticky.

harm-less avatar harm-less commented on August 14, 2024

That's a good point. I'll mark it as a bug and fix it right away. I'll notify you when I made a new patch.

from angular-sticky.

LordMidi avatar LordMidi commented on August 14, 2024

Thx for your efforts. I've updated to 0.2.2 but in my case if (!stickyElementCollection.trackedElements.length) { always validated to true (stickyElementCollection.trackedElements.length is always 0) so there is no change in the behaviour.

from angular-sticky.

LordMidi avatar LordMidi commented on August 14, 2024

Nice. It works. Many thanks for your instant help!

(just one note - maybe you want to switch to 2 spaces instead of tabs for indent. I think it's more common these days)

see ya

from angular-sticky.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.