Use shellcheck about devops-bash-tools HOT 3 OPEN

Thanks for raising this

It is used in CI/CD, but yes pre-commit has been on the backlog

Unfortunately it doesn't catch that typo in the shebang line:

$ shellcheck gcp/gcp_service_accounts_credential_keys_expired.sh
$ echo $?
0

I've just fixed that shebang line.

from devops-bash-tools.

Thanks for finding this one though, that's fixed and I'll keep pre-commit on the todo list anyway as I had other plans for it too

from devops-bash-tools.

@HariSekhon oh dang, you're right! i found that when looking at which shebang lines were used in this repo, not through shellcheck.

$ git grep -h '^#!' | sort | uniq -c
   2 #!**/[Pp]ackages/repositories.config
   1 #!/bin/bash
  23 #!/bin/sh
   1 #!/u)sr/bin/env bash
1151 #!/usr/bin/env bash
   9 #!/usr/bin/env osascript
   1 #!/usr/bin/env python3
   1 #!/usr/local/bin/expect -f

from devops-bash-tools.