Giter Club home page Giter Club logo

Comments (5)

bedis avatar bedis commented on May 28, 2024

Thanks to @oktalz we have a working patch in the branch bind-accept-proxy. That said, I thought a bit more about this feature and I think I want to improve it this way:

  • add an option to provide a list of source IP supposed to send the proxy protocol

The reason is simple: we may have a layer of External Load-balancer which can set the proxy protocol (ELB, HAProxy) and have in the mean time internal clients reaching directly the ingress controller without sending the proxy protocol.
If there is no source IP given with the configuration, then the rule will apply to entire traffic. If there is a list, then we'll enforce proxy protocol to this source IPs only

from kubernetes-ingress.

bedis avatar bedis commented on May 28, 2024

This would be useful as well to put the controller behind ELB

from kubernetes-ingress.

the-nicolas avatar the-nicolas commented on May 28, 2024

Any update here? We have a hardware lb in front of ingress which adds client ip via proxy protocol to tcp connections and we need that information on our application...

from kubernetes-ingress.

bedis avatar bedis commented on May 28, 2024

Well, I did a first implementation "which works" but I was not satisfied by it (it was just a "enable/disable" kind of thing.).
I want something more granular where we can enforce Proxy-Protocol for some source IPs only (or all traffic of course).
but this require support for new tcp-request rules in the client-native library that will be available with v2 of it (in a couple of weeks).
In short, I'll restart working on this one in a couple of weeks.

from kubernetes-ingress.

Mo3m3n avatar Mo3m3n commented on May 28, 2024

Support for proxy-protocol has been added here 8c898cb

from kubernetes-ingress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.