Call to memcpy with overlapping buffers about haproxy HOT 6 CLOSED

Too late. It will probably take me two more decades to get used to this.

In fact it does perform the check, it's just that the check became wrong when I made the zero-copy changes to keep the buffers aligned. Can you please confirm that this patch fixes it ? diff --git a/src/mux_h1.c b/src/mux_h1.c index a5d60c3..d928cef 100644 --- a/src/mux_h1.c +++ b/src/mux_h1.c @@ -1658,7 +1658,7 @@ static size_t h1_process_output(struct h1c *h1c, struct buffer *buf, size_t coun /* when the output buffer is empty, tmp shares the same area so that we * only have to update pointers and lengths. */ - if (tmp->area == h1c->obuf.area) + if (tmp->area == h1c->obuf.area + h1c->obuf.head) h1c->obuf.data = tmp->data; else b_putblk(&h1c->obuf, tmp->area, tmp->data);

Great, now applied to dev, will be backported to 1.9.3 soon.