I also have this issue. Tested yar@2.1.0 and hapi@4.1.4 because travelogue does not su

I already did: <a class="issue-link js-issue-link" data-error-text="Failed to load tit

Session null in onPreResponse about yar HOT 4 CLOSED

chadkouse commented on July 16, 2024

Session null in onPreResponse

from yar.

Comments (4)

reid commented on July 16, 2024

I also have this issue. Tested [email protected] and [email protected] because travelogue does not support hapi 5.x.x.

To reproduce:

Create a yar session, e.g. in your browser.
Change the yar password.
Make another request with the same cookies.
hapi's state handler will fail to parse the cookies. This causes the onPreAuth event to be skipped.
The request.session was never setup by yar's onPreAuth handler, so it will be null by the time onPreResponse comes around.
The server crashes.

Example trace:

Debug: hapi, state, error
    {"name":"session","value":"Fe26.2**cafedbad","settings":{"isSecure":false,"isHttpOnly":false,"path":"/","domain":null,"ttl":null,"encoding":"iron","password":"WAT"},"reason":"Bad hmac value"}

/app/node_modules/yar/lib/index.js:181
        if (!request.session._isModified &&
                            ^
TypeError: Cannot read property '_isModified' of null
    at /app/node_modules/yar/lib/index.js:181:29
    at /app/node_modules/hapi/lib/handler.js:389:22
    at iterate (/app/node_modules/hapi/node_modules/async/lib/async.js:149:13)
    at Object.async.eachSeries (/app/node_modules/hapi/node_modules/async/lib/async.js:165:9)
    at /app/node_modules/hapi/lib/handler.js:372:15
    at internals.Protect.run (/app/node_modules/hapi/lib/protect.js:53:5)
    at Object.exports.invoke (/app/node_modules/hapi/lib/handler.js:370:22)
    at internals.Request._reply (/app/node_modules/hapi/lib/request.js:350:13)
    at /app/node_modules/hapi/lib/request.js:318:18
    at /app/node_modules/hapi/node_modules/async/lib/async.js:151:21

from yar.

chmanie commented on July 16, 2024

Nice. Are you going to create a PR for that?

from yar.

reid commented on July 16, 2024

I already did: #36

On May 22, 2014, at 7:52 AM, Christian Maniewski [email protected] wrote:

Nice. Are you going to create a PR for that?

—
Reply to this email directly or view it on GitHub.

from yar.

lock commented on July 16, 2024

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

from yar.

Recommend Projects