Giter Club home page Giter Club logo

Comments (9)

mistersourcerer avatar mistersourcerer commented on June 16, 2024

Hy @jodosha, can you provide some more context on what do you need here?

from hanami.

jodosha avatar jodosha commented on June 16, 2024

@ricardovaleriano I've updated the description of this ticket with a design proposal.

from hanami.

simi avatar simi commented on June 16, 2024

@jodosha what would session true do? For example in sinatra, similar code is adding Rack::Session::Cookie with given params (for example secret key) to middleware stack.

Now it looks like two session middlewares will be used at the same time for your example.

from hanami.

jodosha avatar jodosha commented on June 16, 2024

@simi from the description:

Please note that sessions true should enable sessions, by including Lotus::Action::Sessions into Bookshelf::Action taking advantage of Lotus::Controller::Configuration#modules.

I'm gonna rethink the proposal, the actual is verbose because of the framework internals.

from hanami.

simi avatar simi commented on June 16, 2024

Damn, I should try to read better.

Anyway, session true is providing only session method for Lotus::Action now. You need to use some session storage middleware always. Can you confirm this?

from hanami.

jodosha avatar jodosha commented on June 16, 2024

@simi I confirm. please have a look at the updated proposal.

from hanami.

mistersourcerer avatar mistersourcerer commented on June 16, 2024

Nice @jodosha, thank you for the clarification.

from hanami.

michalmuskala avatar michalmuskala commented on June 16, 2024

Is anybody doing something about this issue? If not I'd like to help with this.

from hanami.

gotjosh avatar gotjosh commented on June 16, 2024

It's assigned to me but I have plans to work on it over the weekend or by the end of the week. If you'd like to take it for spin and you'll have it completed sooner then I don't mind at all.

from hanami.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.