Giter Club home page Giter Club logo

Comments (9)

hadronized avatar hadronized commented on May 25, 2024 1

Yeah, it’s on me. I’ll patch that soon. I won’t close your issue so that I can use it as backlog, if you don’t mind. The patch is not hard to write, it just requires a bit of refactoring, nothing hard. I’ll do that on this weekend if I find enough spare time.

Thanks again for reaching out!

from luminance-rs.

hadronized avatar hadronized commented on May 25, 2024

I don’t have renderdoc right now. I’ll have a look when I get home. What sampler are you using in your shader?

from luminance-rs.

tinaun avatar tinaun commented on May 25, 2024
Sampler {
    wrap_r: texture::Wrap::Repeat, 
    wrap_s: texture::Wrap::Repeat,
    wrap_t: texture::Wrap::Repeat,
    min_filter: texture::MinFilter::Linear,
    mag_filter: texture::MagFilter::Linear,
    depth_comparison: None,
};
in vec2 fPos;

out vec4 color;

uniform sampler2D tex;

void main() {

    color = vec4(texture(tex, fPos).rgb, 1.0);
    //color = vec4(1.0, 1.0, 1.0, clamp(fPos.x + fPos.y, 0.0, 1.0));
}

from luminance-rs.

hadronized avatar hadronized commented on May 25, 2024

Try with uniform usampler2D tex;, because your texture has an internal format of RGBA8UI.

On a more general note, I need to patch the check code for this. Most uniforms would have yielded a type mismatch (you can try it out), but with arrays and textures, I just assume it’s always ok for now.

from luminance-rs.

tinaun avatar tinaun commented on May 25, 2024

yep, that was it! thanks a bunch. i checked for all uniform warnings, so i didn't think my uniform types could have been off after i didn't get any more warnings! good to know

from luminance-rs.

hadronized avatar hadronized commented on May 25, 2024

OK, I’ll work on that right now.

from luminance-rs.

hadronized avatar hadronized commented on May 25, 2024

@tinaun I’ll release a new version of luminance soon but if you want to test with the current HEAD, you might give it a try! Just use the initial code you posted. You should now have a type mismatch.

from luminance-rs.

tinaun avatar tinaun commented on May 25, 2024

awesome!

from luminance-rs.

hadronized avatar hadronized commented on May 25, 2024

luminance-0.28 ships with it! :)

from luminance-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.