Comments (3)
Hmm, looks like this has been happening for awhile; e.g.:
https://github.com/hackworthltd/primer/actions/runs/8592173489/job/23541841064#step:6:129
We’re about to switch to tasty-bench
, so between that and having just switched benchmark hardware, maybe this is a good time to throw out the old results and start fresh.
I’m not sure why the benchmark results aren’t being cached, though. I’ll compare the hashes of the Nix derivaitons (Buildkite vs GitHub) to see if there’s an impurity somewhere. I’ll also ensure that cachix watch-store
is being run on the benchmarking machine, though perhaps we should go back to Nix-style benchmarking by adding the new benchmarking machine to /etc/nix/machines
in the Buildkite pod on our Kubernetes cluster, which would ensure that the result is cached since the Buildkite pod is definitely writing to Cachix.
from primer.
The Nix hashes are the same, which indicates that the results aren’t being written to Cachix… but it might be the case that we’re writing the benchmark results to our private Cachix cache and not the public cache that the GitHub workflow relies on. (Nope, scratch that bit — the benchmark GitHub workflow does have access to the private Cachix, and in fact you can see it downloading some Nix derivations from there during the workflow.)
from primer.
This has been fixed.
from primer.
Related Issues (20)
- Are we building (should we build) dependencies with `-O2`
- More robust Wasm support
- When looking for matches for holes, prefer local bindings over top-level/in-scope module binding
- Future work on interpreter
- wasm: always build with `-O2`
- Property test failure (possibly Wasm-related?) HOT 1
- Primer language -> Wasm compiler HOT 1
- Compile Primer programs to Wasm
- Only run Wasm tests on merge queue or workflow dispatch HOT 2
- Use Buildkite artifacts to cache Wasm build artifacts HOT 1
- `primer-service`: look into RFC 9457
- Duplication in interpreter implementation
- Hook interpreter up to API
- `tasty_two_interp_agree` property test failure HOT 4
- `tasty_redex_independent` property test failure
- `tasty_multiple_requests_accepted` property test failures HOT 2
- `RecordPair TyConName ValConName` does not serialize nicely in the OpenAPI API
- Interpreter can't reduce top-level definitions
- Investigate `weeder-nix`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primer.