Allow using HTML tags MARK and ABBR in H5P content types about h5p-php-library HOT 5 CLOSED

Adding additional tags would prevent them from being filtered out (in https://github.com/h5p/h5p-editor-php-library/blob/master/scripts/h5peditor-html.js#L523-L531), but the editor would not display corresponding buttons for adding them (https://github.com/h5p/h5p-editor-php-library/blob/master/scripts/h5peditor-html.js#L38).

It would be up to the content type author to allow them, but there's no guarantee that the current handler will remain the same (in particular once the CKEditor gets replaced), so I am going to stick to the list of tags in the specification.

/cc @boyum

from h5p-php-library.

By adding mark and abbr to the list of tags on the field in the content type's semantics, these tags can be used. In this case, I've typed in <mark>marked text</mark> and <abbr title="abbreviation">abbr</abbr> to the text field, which seems to work as expected.

⚠️ As the tags are not mentioned in the docs, they might not be officially supported. Do you think it's safe to use, @otacke?

from h5p-php-library.

@boyum @otacke Thank you for your responses. I do actually not need the editor to display the corresponding buttons to use these tags in the content text. For me it's easy enough to copy/paste the already formatted text into the editor. I would only need these tags to not be stripped out again. I'm unsure to where the changes need to be done if we talk about the Agamotto content type:

• Here?: tags in Agamotto image descriptions
• Here?: default tags in h5p editor

And I'm also unsure who could do these changes? Would you be able to make these additions in your source code, would I (or our hosting company) need to fork away or would this be a simple configuration change in our instance https://academy.siscc.org/?

Thanks again for your kind help on this.

from h5p-php-library.

@dosse I fully understood that. You don't need them. But obviously H5P Group tries not to have too many "hidden features" that are not obvious to the common user.

As I said, I am going to stick to the list of tags in the specification. But you can fork or simply use H5P's Authoring tool customization and add those tags via hooks. No need to touch any of the original code or to live with a fork, but if you share the content, on other platforms the extra tags will be filtered out.

from h5p-php-library.

@otacke Thanks for the quick response! We will try your suggestion.

from h5p-php-library.