Giter Club home page Giter Club logo

Comments (3)

mmomtchev avatar mmomtchev commented on August 10, 2024

This is what I do to manually count the frames w/ resynchronization on the input stream when it is possible:
master...mmomtchev:avcpp:example-pts-dts

from avcpp.

mmomtchev avatar mmomtchev commented on August 10, 2024

There are two separate issues that prevent the clean teardown

First one:

if (inFrame && inFrame.timeBase() != Rational()) {

There are two possible sources for the timebase here - either from the current frame - which works for all frames except the last one where the encoder is called with an empty frame - either from m_stream when m_stream.isValid(). However the encoder is not constructed with the stream - only the decoder is. The encoder must use its own timebase field here - and all three options must be mutually exclusive - currently a valid stream will replace the timebase of the frame.

Second one:

if (ret < 0 && ret != AVERROR(EAGAIN))

This should be:
if (ret < 0 && ret != AVERROR(EAGAIN) && ret != AVERROR_EOF)
just like in the function above and below it

from avcpp.

h4tr3d avatar h4tr3d commented on August 10, 2024

Thanks for reporting and fix!

from avcpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.