Comments (7)
kazuho
commented on July 17, 2024
1
Submodule deps/picotest is outdated. Please run git submodule update --init --recursive.
from picotls.
huitema
commented on July 17, 2024
1
My fault. Developing this code, I used the API mbedtls_pk_load_file because it was a convenient way to load in memory the text content of a file. But this API was removed in the last versions of MbedTLS. I should have a replacement pretty soon.
from picotls.
huitema
commented on July 17, 2024
1
The fix is ready in PR #519. I am waiting for review by @kazuho to check it in main.
from picotls.
huitema
commented on July 17, 2024
1
Actually, I had to close PR #519, and restart with PR #528. The good news is that this now a complete implementation, with support for loading private keys and verifying certificates. That PR is ready, waiting for reviews before check-in.
from picotls.
barracuda156
commented on July 17, 2024
@kazuho Thank you, you are right, those errors are gone with picotest updated to the current commit.
I can build picotls now with gcc locally with no failures, however I see failures with clang on CI:
/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_picotls/picotls/work/picotls-9de892ccf7b1d3dc9467ef92ba9314c155928037/lib/mbedtls_sign.c:619:16: error: call to undeclared function 'mbedtls_pk_load_file'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if ((ret = mbedtls_pk_load_file(pem_fname, &buf, &n)) != 0) {
^
/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_picotls/picotls/work/picotls-9de892ccf7b1d3dc9467ef92ba9314c155928037/lib/mbedtls_sign.c:619:16: note: did you mean 'mbedtls_mpi_read_file'?
/opt/local/include/mbedtls/bignum.h:517:5: note: 'mbedtls_mpi_read_file' declared here
int mbedtls_mpi_read_file(mbedtls_mpi *X, int radix, FILE *fin);
^
1 error generated.
make[2]: *** [CMakeFiles/picotls-mbedtls.dir/lib/mbedtls_sign.c.o] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_picotls/picotls/work/build'
make[1]: *** [CMakeFiles/picotls-mbedtls.dir/all] Error 2
from picotls.
barracuda156
commented on July 17, 2024
@huitema Please ping me once ready, I will update the port in MacPorts then.
from picotls.
barracuda156
commented on July 17, 2024
@huitema Thank you! I will update our port once the PR gets merged.
from picotls.
Related Issues (20)
- Generating qlog files when using quicly as a library
- Conditional jump or move depends on uninitialised value(s) HOT 9
- Open SSL version not recognized on MacOS Ventura 13.2 HOT 6
- cmake fails on clean install HOT 1
- in ptls_import / ptls_export, take care of partial TLS record being received
- Adding a new crypto engine HOT 4
- no error handling of key_schedule_new failure
- We should document ECH, update the ESNI wiki page.
- picotls build seems to fail? HOT 2
- Perhaps require appropriate C standard? Pre-C11 compiler fails: `picotls.c: error: ‘ptls_handshake_properties_t’ has no member named ‘client’`
- Possible integer overflow when checking obfuscated ticket age
- Ticket issued time does not compensate for RTT
- OpenSSL RSA private key default format changes to PKCS#8
- Build error with Clang on 10.6–10.7: `error: call to undeclared library function 'aligned_alloc' with type 'void *(unsigned long, unsigned long)'; ISO C99 and later do not support implicit function declarations`
- test-openssl.t has a few failing tests HOT 4
- cli can not parse argument '-u'
- when cli act as server with client authentication, it sends NewSessionTicket directly after Finished
- Should exclude PSK_DHE mode when key_share is null
- External PSK auth may fail with missing_extension (109) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from picotls.