Giter Club home page Giter Club logo

Comments (5)

AdrianEddy avatar AdrianEddy commented on June 19, 2024

Hmm, that sounds like Kdenlive bug, beause in the plugin code, the path is not altered at all, never, it's just always treated as a string. The parameter is just string too, not path. The Path parameter type is created and handled by Kdenlive (based on the xml)

from gyroflow-frei0r.

RonOnGithub avatar RonOnGithub commented on June 19, 2024

Yeah, that was my first thought too, but after a bit of digging, the project file xml does seem to be quite consistent about making paths under the <mlt root=''> relative to it, and I found this report against mlt mltframework/shotcut#710 which seems to indicate this is intentional.

I couldn't find another effect which uses a path to see how it handled this, but it would seem a little odd to have the path in the xml project file to the .gyroflow file be absolute when the path to the video source is relative. I'm seeing:

<property name="Project">footage/PRO_VID_20240410_064418_018.gyroflow
<property name="kdenlive:originalurl">footage/PRO_VID_20240410_064418_018.mp4
<property name="kdenlive:original.resource">footage/PRO_VID_20240410_064418_018.mp4

Can we access the mlt root parameter in lib.rs to create a full path there, or do we really need kdenlive (actually mlt in this case) to pass us something more?

I can open an issue on the kdenlive side, but if we can fix it on this side by normalising the Project path if it is relative, that does seem like the most robust answer to my current (slim) understanding of what's happening in this code.

from gyroflow-frei0r.

AdrianEddy avatar AdrianEddy commented on June 19, 2024

There's really nothing I can do on my side, the frei0r interface is dead simple and doesn't have any control over host application or anything host-specific. All that gyroflow plugin handles in lib.rs is a single String. The interpretation of it as a path is entirely on the host side and invisible to the frei0r plugin

from gyroflow-frei0r.

RonOnGithub avatar RonOnGithub commented on June 19, 2024

Ok, thanks for clarifying that. I started out looking at whether the parameter type for Project needed to be something other than 'url' in frei0r_gyroflow.xml, but then I wasn't sure if we also had access to more than just those parameter values. I'll leave this open here for now so we've got somewhere to track this side of the discussion, and if we need to bounce some more questions off you, but I'll take it up on the kdenlive side and figure out what needs to be done there. Thanks for the fast response!

from gyroflow-frei0r.

AdrianEddy avatar AdrianEddy commented on June 19, 2024

In theory it would work if you could set the parameter in xml to string and just type the full path there manually, but it appears that there's no such type in the effect xml

from gyroflow-frei0r.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.