Comments (5)
Well, this one was intentional. Because zone voltage is something that fluctuates rather rapidly I didn't see the use of syncing it. And, it will not automatically update when it changes. Happy to be convinced differently.
One thing that could be done which is a feature request is to add a helper to retrieve the zone voltage. It can already be retrieved just that the couple of lines of code of the helper simplifies retrieval ever so slightly.
from elkm1.
I've had requests from users to show zone voltage, so I was looking at adding it.
I am seeing the callback come thru with voltage changes, but not all changes. I don't have elkm1_lib debugging on, but can enable that if you want to see more
2021-02-03 22:40:04,083 ELK-13600 polyinterface DEBUG Zone:callback: Guest Window 1: changeset={'voltage': 7.1}
A simple helper would be great if you feel it should not be synced on startup or change. But it may not be valuable to users if it doesn't update when changed automatically.
from elkm1.
I added get_voltage
helper on the Zone. It is in version 0.8.11 that was just published.
With respect to the zone callback with voltage that you reference, the library has never requested voltage before so that would mean something is calling zv_encode and send outside of the library (which is all the helper does, it just puts a nice wrapper on it).
Just in case you care, all the helpers are consistently labelled with (Helper)
in their docs. I use it to discover all the helpers that exist. See https://github.com/gwww/elkm1/blob/main/bin/cmdr.py#L76-L91
from elkm1.
Thanks for adding get_voltage.
I've no idea how all the callback is coming with voltage, I'm not calling zv_encode, but it seems to happen some time after a periodic panel resync is run?
Thanks for the get_helper info, I'll check it out.
from elkm1.
I'm curious to know the answer to this. I don't see voltage come through unless I ask for it.
Going to close this. Can reopen if there's something you think the library can offer here.
from elkm1.
Related Issues (20)
- [Enhancement] Add a contributing.md to the project.
- Can't install the lib elk_m1 HOT 4
- [BUG] Zone change callback called twice with same changeset HOT 5
- [BUG] HOT 2
- Requirement is pinned for elkm1-lib 0.8.8: pyserial-asyncio>=0.4.0,<0.5.0 HOT 1
- [Enhancement] Know if a Zone can be bypassed HOT 2
- [Enhancement] Discovery Support
- Question: Ever seen Keypad Zero? HOT 3
- [Enhancement] How to get F or C configuration from panel HOT 3
- [Enhancement] Tag releases on GitHub HOT 2
- Elk M1G SSL Error after updating M1XEP to v 2.0.46 HOT 7
- Request for Assistance HOT 24
- [BUG] ValueError in zc_decode HOT 2
- [BUG] Frequent disconnects with latest version HOT 4
- [BUG] RuntimeError: list changed size during iteration HOT 6
- [Enhancement] Report zone specific system trouble to the zone instead of the panel HOT 2
- [Enhancement] Question about Toggling ArmedStatus
- pyserial-asyncio does blocking I/O in the event loop HOT 2
- Areas are incorrectly labeled as configured [BUG] HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elkm1.