Giter Club home page Giter Club logo

Comments (5)

gwww avatar gwww commented on July 19, 2024

Well, this one was intentional. Because zone voltage is something that fluctuates rather rapidly I didn't see the use of syncing it. And, it will not automatically update when it changes. Happy to be convinced differently.

One thing that could be done which is a feature request is to add a helper to retrieve the zone voltage. It can already be retrieved just that the couple of lines of code of the helper simplifies retrieval ever so slightly.

from elkm1.

jimboca avatar jimboca commented on July 19, 2024

I've had requests from users to show zone voltage, so I was looking at adding it.
I am seeing the callback come thru with voltage changes, but not all changes. I don't have elkm1_lib debugging on, but can enable that if you want to see more

2021-02-03 22:40:04,083 ELK-13600  polyinterface      DEBUG    Zone:callback: Guest Window 1: changeset={'voltage': 7.1}

A simple helper would be great if you feel it should not be synced on startup or change. But it may not be valuable to users if it doesn't update when changed automatically.

from elkm1.

gwww avatar gwww commented on July 19, 2024

I added get_voltage helper on the Zone. It is in version 0.8.11 that was just published.

With respect to the zone callback with voltage that you reference, the library has never requested voltage before so that would mean something is calling zv_encode and send outside of the library (which is all the helper does, it just puts a nice wrapper on it).

Just in case you care, all the helpers are consistently labelled with (Helper) in their docs. I use it to discover all the helpers that exist. See https://github.com/gwww/elkm1/blob/main/bin/cmdr.py#L76-L91

from elkm1.

jimboca avatar jimboca commented on July 19, 2024

Thanks for adding get_voltage.

I've no idea how all the callback is coming with voltage, I'm not calling zv_encode, but it seems to happen some time after a periodic panel resync is run?

Thanks for the get_helper info, I'll check it out.

from elkm1.

gwww avatar gwww commented on July 19, 2024

I'm curious to know the answer to this. I don't see voltage come through unless I ask for it.

Going to close this. Can reopen if there's something you think the library can offer here.

from elkm1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.