Giter Club home page Giter Club logo

Comments (5)

niloc132 avatar niloc132 commented on August 15, 2024

Thanks, can you propose a pull request for this? This has come up a few times, but haven't gotten a complete patch for it.

See #9635 and #9602. Based on discussion there, it looks like there are two sites to fix for this.

from gwt.

DRAWSVG avatar DRAWSVG commented on August 15, 2024

Hello,
I fix the bug on a local cloned repository with three modifications (once the first exception is fixed there are still two others.).
The report is produced on my project without exception (more than 3000 java classes with 60 split points).
The StoryRecorder code is quite confused, the correction should be validated by the author of the code.

Here the three corrections:
Line 172:
// Infer dependency information
while (!dependencyScope.isEmpty() && !dependencyScope.peek().range.contains(range)) {
/*
* Pop frames until we get back to a container, using this as a chance
* to build up our list of non-overlapping Ranges to report back to the
* user.
*/
popAndRecord(dependencyScope, fragment);
}

Line 272 (StringIndexOutOfBoundsException) :
SizeMapRecorder.escapeXml(jsCode, start, Math.min(end,jsCode.length()), false, builder);

Line 300 (EmptyStackException) :
if (lastEnd < toStore.getStart() && !dependencyScope.isEmpty()) {

from gwt.

niloc132 avatar niloc132 commented on August 15, 2024

The original authors are no longer involved with this project, so we're relying on community members who take the time to find and understand a bug, and propose a fix. Standard github pull requests can be used to submit fixes, and we can help run tests etc to confirm the fix.

As an aside, a huge number of split points often comes with the symptom that many of those split points do not remove very much code - yet still add a substantial amount to the build time.

from gwt.

DRAWSVG avatar DRAWSVG commented on August 15, 2024

I don't have write permissions on the project

from gwt.

niloc132 avatar niloc132 commented on August 15, 2024

Correct. You need to fork the project, push a branch with your changes, and create a pull request.

from gwt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.