Giter Club home page Giter Club logo

Comments (5)

Tobion avatar Tobion commented on May 1, 2024

According to PSR-7 this should not happen.

If the port is the standard port used with the current scheme, this method SHOULD return null.

So this issue can be closed.

from psr7.

timmillwood avatar timmillwood commented on May 1, 2024

Maybe I need a word with the PHP-FIG.

from psr7.

Tobion avatar Tobion commented on May 1, 2024

I don't think it's a problem as it is per RFC 3986 that the port should be removed when it's the default.
And in the end it should not matter as the URIs are equal. And as a consumer you need to handle both null and the default port anyway from getPort as either can happen.

from psr7.

timmillwood avatar timmillwood commented on May 1, 2024

Right, currently I'm doing

$port = $uri->getPort();
if (empty($port)) {
    $port = ($uri->getScheme() == 'https') ? 443 : 80;
}

from psr7.

Tobion avatar Tobion commented on May 1, 2024

If you need the actual port, this is the way to go. (But I would explicitly test again null)

from psr7.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.