Relative URI > Can't parse_url if colon is present about psr7 HOT 8 CLOSED

Can you provide a concrete example?

Please note thought that one of the things I want to avoid is having to implement a custom URI parser to account for things like this. It would be slow and would be a maintenance burden. If this ends up being a limitation of PHP's parse_url, then I think we would just chalk it up as a "known issue".

from psr7.

I've experimented some more and found even more constraints to the condition. Now I'm pretty sure this should be a known issue.

I'll update the initial description with the further constraints and an example.

FWIW: My particular use case was a RESTful API with an resource id of the format <class>:<id> specified in the URL.

Working around this problem is fairly easy: either specify a query or a fragment or at least leave a dangling question mark at the end.

from psr7.

Should I close the issue or will you close it with a particular status/label?

from psr7.

Hm... I wonder if there's something we can do here, at least for the case of combining URIs... For example, maybe we can have a special case for combining with a relative URI that starts with '/'?

from psr7.

Simple fix would be (in the context of initializing relative paths) to add a question mark if one is not already present.

        if (!($rel instanceof UriInterface)) {
            $rel = ($rel[0] === '/' and strpos($rel, '?') === false) ? $rel.'?' : $rel;
            $rel = new self($rel);
        }

from psr7.

Is there a PHP bug report for this? https://3v4l.org/QMNeo definitely seems like a PHP bug.

from psr7.

@Tobion not one that I found but parse_url might very well have been intended to parse complete URLs (containing scheme, authentication, domain, tld, port, path, query, fragment, etc.).

Using parse_url for relative paths could be regarded as improper usage. Which is why I didn't pursue it as a PHP bug per se.

from psr7.

But it parses relative urls correctly for the most part like //example.org and /path. So either it parses only absolute URIs and needs to return false for anything else. Or it must parse relative URIs correctly as well.

from psr7.