Giter Club home page Giter Club logo

Comments (3)

jeskew avatar jeskew commented on May 1, 2024

This sounds more like an issue with the test than an issue with the stream implementation. If a file handle allows you to seek past its end, then I don't think this library should be reporting that as a failure.

Maybe the test should be refactored so as not to rely on a php://temp streams implementation? It looks like this is the only test failing on HHVM on Travis.

from psr7.

mtdowling avatar mtdowling commented on May 1, 2024

Yeah, I think this is a bad test more than anything.

from psr7.

Tobion avatar Tobion commented on May 1, 2024

I think the easiest solution is to skip the test on hhvm as the behavior is indeed different: https://3v4l.org/TXNdR
And I don't see a way to make the same test for both php and hhvm work. I don't know any other stream that is seekable but not past the end.

from psr7.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.