Giter Club home page Giter Club logo

Comments (3)

mtdowling avatar mtdowling commented on May 1, 2024

Sounds fine to me.

On Jul 7, 2015, at 3:24 PM, Nicolas [email protected] wrote:

I was wondering why parse_request doesn't support absolute URI's. Request like this fail:

GET https://www.google.com HTTP/1.1
The regex explicity requires a starting slash after the keyword:

if (!preg_match('/^[a-zA-Z]+\s+/.*/', $data['start-line'])) {
throw new \InvalidArgumentException('Invalid request string');
}
Are there any objections to support absolute URI's as well? I'm trying to build a php proxy server using reactphp/http (which uses guzzle/psr7) and it doesn't work because of this. If no objections I can create a PR.

Best,
Nicolas

β€”
Reply to this email directly or view it on GitHub.

from psr7.

poison avatar poison commented on May 1, 2024

Were you able to check my PR #25 ? Any comments on it ?

Best,
Nicolas

from psr7.

mtdowling avatar mtdowling commented on May 1, 2024

PR #25 looks good, but I added a question to it: #25 (comment)

from psr7.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.